1455453 - Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Daniel Holbert [:dholbert]]

Followup to bug 1265342 -- as of "Part 3" there, it looks like the FloatInfo constructor will be calling "mFrame->StyleDisplay()" up to 3 times.

The first time we need to call it, let's save it in a local variable, e.g.
   const nsStyleDisplay* disp = mFrame->StyleDisplay()

...and then use that rather than making calls to the function below.


(Trivial nit, but doesn't need to hold up bug 1265342 & I don't want it to get in the way of any less-trivial nits, so filing as a followup.)

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1455453 - Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor.

Review commit: https://reviewboard.mozilla.org/r/250642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250642/

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8984842 [details]
Bug 1455453 - Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor.

https://reviewboard.mozilla.org/r/250642/#review256928

Looks good! Thanks TYLin :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffdeb96ca6d0
Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor. r=dholbert

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Thanks for the review :)

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ffdeb96ca6d0