Closed Bug 1455453 Opened 2 years ago Closed 2 years ago

Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: dholbert, Assigned: TYLin)

References

Details

Attachments

(1 file)

Followup to bug 1265342 -- as of "Part 3" there, it looks like the FloatInfo constructor will be calling "mFrame->StyleDisplay()" up to 3 times.

The first time we need to call it, let's save it in a local variable, e.g.
   const nsStyleDisplay* disp = mFrame->StyleDisplay()

...and then use that rather than making calls to the function below.


(Trivial nit, but doesn't need to hold up bug 1265342 & I don't want it to get in the way of any less-trivial nits, so filing as a followup.)
Priority: -- → P3
Comment on attachment 8984842 [details]
Bug 1455453 - Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor.

https://reviewboard.mozilla.org/r/250642/#review256928

Looks good! Thanks TYLin :)
Attachment #8984842 - Flags: review?(dholbert) → review+
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ffdeb96ca6d0
Coalesce calls to mFrame->StyleDisplay() in FloatInfo constructor. r=dholbert
Thanks for the review :)
Assignee: bwerth → aethanyc
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/ffdeb96ca6d0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.