1455533 - Devirtual some methods in nsIEditor that doesn't use by script

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

The following methods are unused from script (Firefox, c-c and bluegriffon).

- syncRealTimeSpell
- postCreate

The following method are unused from C++/script (Firefox, c-c and bluegriffon).

- outputToStream

Comment 1

[Makoto Kato [:m_kato]]

syncRealTimeSepll
https://github.com/therealglazou/bluegriffon/search?utf8=%E2%9C%93&q=syncRealTimeSpell&type=
https://dxr.mozilla.org/comm-central/search?q=syncRealTimeSpell&redirect=true

postCreate
https://github.com/therealglazou/bluegriffon/search?utf8=%E2%9C%93&q=postCreate&type=
https://dxr.mozilla.org/comm-central/search?q=postCreate

outputToStream
https://github.com/therealglazou/bluegriffon/search?utf8=%E2%9C%93&q=outputToStream&type=
https://dxr.mozilla.org/comm-central/search?q=outputToStream

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1455533 - Part 1. Devirtualize EditorBase::SyncRealTimeSpell.

No one uses syncRealTimeSpell from script even if c-c and BlueGriffon. So
we should devirtualize this

Review commit: https://reviewboard.mozilla.org/r/238322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238322/

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1455533 - Part 2. Devirtualize EditorBase::PostCreate.

No one uses postCreate from script even if c-c and BlueGriffon. So we should
devirtualize this

Review commit: https://reviewboard.mozilla.org/r/238324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238324/

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1455533 - Part 3. Remove unused nsIEditor.outputToStream.

No one uses outputToStream even if c-c and BlueGriffon.  We should remove this.

Review commit: https://reviewboard.mozilla.org/r/238326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238326/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8969689 [details]
Bug 1455533 - Part 1. Devirtualize EditorBase::SyncRealTimeSpell.

https://reviewboard.mozilla.org/r/238322/#review244526

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8969690 [details]
Bug 1455533 - Part 2. Devirtualize EditorBase::PostCreate.

https://reviewboard.mozilla.org/r/238324/#review244528

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8969691 [details]
Bug 1455533 - Part 3. Remove unused nsIEditor.outputToStream.

https://reviewboard.mozilla.org/r/238326/#review244530

::: editor/libeditor/TextEditor.cpp:1331
(Diff revision 1)
>    NS_ENSURE_ARG_POINTER(aCanDelete);
>    *aCanDelete = IsModifiable() && CanCutOrCopy(ePasswordFieldAllowed);
>    return NS_OK;
>  }
>  
> -// Shared between OutputToString and OutputToStream
> +// Shared by OutputToString

s/Shared by/Used by ?

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 8969691 [details]
Bug 1455533 - Part 3. Remove unused nsIEditor.outputToStream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238326/diff/1-2/

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 3ebb52378834b5080a4d9b87c9f91d6a01177470 -d 22a1e2529011: rebasing 459880:3ebb52378834 "Bug 1455533 - Part 1. Devirtualize EditorBase::SyncRealTimeSpell. r=masayuki"
merging editor/libeditor/EditorBase.cpp
merging editor/libeditor/EditorBase.h
merging editor/nsIEditor.idl
rebasing 459881:83ff97a7ebe5 "Bug 1455533 - Part 2. Devirtualize EditorBase::PostCreate. r=masayuki"
merging editor/libeditor/EditorBase.cpp
merging editor/libeditor/EditorBase.h
merging editor/nsIEditor.idl
rebasing 459882:265fba569db4 "Bug 1455533 - Part 3. Remove unused nsIEditor.outputToStream. r=masayuki" (tip)
merging editor/libeditor/EditorBase.cpp
merging editor/libeditor/TextEditor.cpp
merging editor/libeditor/TextEditor.h
merging editor/nsIEditor.idl
warning: conflicts while merging editor/libeditor/TextEditor.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db8d706159df
Part 1. Devirtualize EditorBase::SyncRealTimeSpell. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f70e84b0a32
Part 2. Devirtualize EditorBase::PostCreate. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcfb7f0bb6a9
Part 3. Remove unused nsIEditor.outputToStream. r=masayuki

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/db8d706159df
https://hg.mozilla.org/mozilla-central/rev/0f70e84b0a32
https://hg.mozilla.org/mozilla-central/rev/dcfb7f0bb6a9