Closed Bug 1455533 Opened 6 years ago Closed 6 years ago

Devirtual some methods in nsIEditor that doesn't use by script

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

The following methods are unused from script (Firefox, c-c and bluegriffon).

- syncRealTimeSpell
- postCreate

The following method are unused from C++/script (Firefox, c-c and bluegriffon).

- outputToStream
Assignee: nobody → m_kato
Comment on attachment 8969689 [details]
Bug 1455533 - Part 1. Devirtualize EditorBase::SyncRealTimeSpell.

https://reviewboard.mozilla.org/r/238322/#review244526
Attachment #8969689 - Flags: review?(masayuki) → review+
Comment on attachment 8969690 [details]
Bug 1455533 - Part 2. Devirtualize EditorBase::PostCreate.

https://reviewboard.mozilla.org/r/238324/#review244528
Attachment #8969690 - Flags: review?(masayuki) → review+
Comment on attachment 8969691 [details]
Bug 1455533 - Part 3. Remove unused nsIEditor.outputToStream.

https://reviewboard.mozilla.org/r/238326/#review244530

::: editor/libeditor/TextEditor.cpp:1331
(Diff revision 1)
>    NS_ENSURE_ARG_POINTER(aCanDelete);
>    *aCanDelete = IsModifiable() && CanCutOrCopy(ePasswordFieldAllowed);
>    return NS_OK;
>  }
>  
> -// Shared between OutputToString and OutputToStream
> +// Shared by OutputToString

s/Shared by/Used by ?
Attachment #8969691 - Flags: review?(masayuki) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 3ebb52378834b5080a4d9b87c9f91d6a01177470 -d 22a1e2529011: rebasing 459880:3ebb52378834 "Bug 1455533 - Part 1. Devirtualize EditorBase::SyncRealTimeSpell. r=masayuki"
merging editor/libeditor/EditorBase.cpp
merging editor/libeditor/EditorBase.h
merging editor/nsIEditor.idl
rebasing 459881:83ff97a7ebe5 "Bug 1455533 - Part 2. Devirtualize EditorBase::PostCreate. r=masayuki"
merging editor/libeditor/EditorBase.cpp
merging editor/libeditor/EditorBase.h
merging editor/nsIEditor.idl
rebasing 459882:265fba569db4 "Bug 1455533 - Part 3. Remove unused nsIEditor.outputToStream. r=masayuki" (tip)
merging editor/libeditor/EditorBase.cpp
merging editor/libeditor/TextEditor.cpp
merging editor/libeditor/TextEditor.h
merging editor/nsIEditor.idl
warning: conflicts while merging editor/libeditor/TextEditor.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db8d706159df
Part 1. Devirtualize EditorBase::SyncRealTimeSpell. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f70e84b0a32
Part 2. Devirtualize EditorBase::PostCreate. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcfb7f0bb6a9
Part 3. Remove unused nsIEditor.outputToStream. r=masayuki
You need to log in before you can comment on or make changes to this bug.