1455551 - NS_IMPL_FROMNODE_HELPER and friends should live in nsINode.h now.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1454251 where I had to add an nsIContent.h include for Attr.h just because.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1455551: Move NS_IMPL_FROMNODE_HELPER and friends to nsINode.h.

Review commit: https://reviewboard.mozilla.org/r/238330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238330/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969573 [details]
Bug 1455551: Move NS_IMPL_FROMNODE_HELPER and friends to nsINode.h.

https://reviewboard.mozilla.org/r/238330/#review244212

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2313b8b16c1aa5053c91f036d871f58aa42a6e87 -d ed1028a2a78c: rebasing 459585:2313b8b16c1a "Bug 1455551: Move NS_IMPL_FROMNODE_HELPER and friends to nsINode.h. r=bz" (tip)
merging dom/base/Attr.h
merging dom/base/nsIContent.h
merging dom/base/nsINode.h
warning: conflicts while merging dom/base/nsIContent.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d377882ca87
Move NS_IMPL_FROMNODE_HELPER and friends to nsINode.h. r=bz

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4d377882ca87