Closed Bug 1455578 Opened 6 years ago Closed 6 years ago

Remove obsolete nsIXULBrowserWindow::setJSStatus

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

      No description provided.
Comment on attachment 8969608 [details]
Bug 1455578 - Remove obsolete nsIXULBrowserWindow::setJSStatus.

https://reviewboard.mozilla.org/r/238384/#review244278

::: dom/base/nsGlobalWindowOuter.cpp:3066
(Diff revision 1)
>  void
>  nsGlobalWindowOuter::SetStatusOuter(const nsAString& aStatus)
>  {
>    mStatus = aStatus;
>  
> -  /*
> +  // We don't support displaying window.status in the UI, so there's nothing

Thunderbird does support it, but it looks like this would only be relevant for cases when chrome script does .status = "something" on a window, and at first glance nothing in mailnews does that.  Still, maybe worth filing a Thunderbird bug to let them know this is going away.

::: toolkit/components/browser/nsIWebBrowserChrome.idl:20
(Diff revision 1)
>  
>  [scriptable, uuid(E8C414C4-DC38-4BA3-AB4E-EC4CBBE22907)]
>  interface nsIWebBrowserChrome : nsISupports
>  {
> -    const unsigned long STATUS_SCRIPT         = 0x00000001;
>      const unsigned long STATUS_LINK           = 0x00000003;

Since this is the only status type remaining, maybe file a followup to remove the concept and generally simplify/rename the code associated with status updates?
Attachment #8969608 - Flags: review?(bzbarsky) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1382278840ed
Remove obsolete nsIXULBrowserWindow::setJSStatus. r=bz
Blocks: 1455710
Blocks: 1455712
Blocks: 1455716
https://hg.mozilla.org/mozilla-central/rev/1382278840ed
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.