1455578 - Remove obsolete nsIXULBrowserWindow::setJSStatus

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1455578 - Remove obsolete nsIXULBrowserWindow::setJSStatus.

Review commit: https://reviewboard.mozilla.org/r/238384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238384/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969608 [details]
Bug 1455578 - Remove obsolete nsIXULBrowserWindow::setJSStatus.

https://reviewboard.mozilla.org/r/238384/#review244278

::: dom/base/nsGlobalWindowOuter.cpp:3066
(Diff revision 1)
>  void
>  nsGlobalWindowOuter::SetStatusOuter(const nsAString& aStatus)
>  {
>    mStatus = aStatus;
>  
> -  /*
> +  // We don't support displaying window.status in the UI, so there's nothing

Thunderbird does support it, but it looks like this would only be relevant for cases when chrome script does .status = "something" on a window, and at first glance nothing in mailnews does that.  Still, maybe worth filing a Thunderbird bug to let them know this is going away.

::: toolkit/components/browser/nsIWebBrowserChrome.idl:20
(Diff revision 1)
>  
>  [scriptable, uuid(E8C414C4-DC38-4BA3-AB4E-EC4CBBE22907)]
>  interface nsIWebBrowserChrome : nsISupports
>  {
> -    const unsigned long STATUS_SCRIPT         = 0x00000001;
>      const unsigned long STATUS_LINK           = 0x00000003;

Since this is the only status type remaining, maybe file a followup to remove the concept and generally simplify/rename the code associated with status updates?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1382278840ed
Remove obsolete nsIXULBrowserWindow::setJSStatus. r=bz

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1382278840ed