Open Bug 1455602 Opened 2 years ago Updated 1 year ago

Intermittent browser/components/sessionstore/test/browser_restore_reversed_z_order.js | Third restored tab is correct - "About About" == "New Tab" - JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_restore

Categories

(Firefox :: Session Restore, defect, P5)

defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])

Attachments

(1 file, 1 obsolete file)

Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=174739782&repo=autoland

https://queue.taskcluster.net/v1/task/SnpywL7lQgyJdQaa8vjbgA/runs/0/artifacts/public/logs/live_backing.log

04:25:38     INFO - TEST-PASS | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | First restored tab should be last used tab - "Gort! Klaatu barada nikto!" == "Gort! Klaatu barada nikto!" - 
04:25:38     INFO - TEST-PASS | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | Second restored tab is correct - "Licenses" == "Licenses" - 
04:25:38     INFO - Buffered messages finished
04:25:38     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | Third restored tab is correct - "About About" == "New Tab" - JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_restore_reversed_z_order.js :: test_windows_are_restored_in_reversed_z_order :: line 73
04:25:38     INFO - Stack trace:
04:25:38     INFO - chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_restore_reversed_z_order.js:test_windows_are_restored_in_reversed_z_order:73
04:25:38     INFO - TEST-PASS | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | Last restored tab should be a minimized window - "The Book of Mozilla, 11:14" == "The Book of Mozilla, 11:14" - 
04:25:38     INFO - Leaving test bound test_windows_are_restored_in_reversed_z_order
04:25:38     INFO - GECKO(871) | MEMORY STAT | vsize 4859MB | residentFast 961MB | heapAllocated 345MB
04:25:38     INFO - TEST-OK | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | took 11945ms

Seems that this push has changed the file mentioned above https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=74478b16e546d7c5c9c77552efb5f16a49811502&group_state=expanded&filter-searchStr=bc5
Flags: needinfo?(mdeboer)
See Also: → 1034036
Looking at the test I can't tell straight away what the issue may be that the tab/ page in question ('about:about') doesn't load and stays at about:newtab for the entirety of the restore process.
It would be great if I could reproduce this locally, but so far I've been unlucky in that regard.
Flags: needinfo?(mdeboer)
There have been 67 failures in the last 7 days.

Failures per platform and build type:
- osx-10-10 / debug & opt: 27
- linux64 / opt, pgo, debug, asan: 21
- windows10-64 / debug & asan: 8
- linux32 / opt & debug: 7
- windows7-32 / pgo & opt: 2
- linux64-ccov / debug: 1
- macosx64-nightly / opt: 1

Recent relevant log file and snippet with the failure:
https://treeherder.mozilla.org/logviewer.html#?job_id=194666559&repo=mozilla-inbound&lineNumber=3482

00:08:34     INFO - TEST-PASS | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | First restored tab should be last used tab - "Gort! Klaatu barada nikto!" == "Gort! Klaatu barada nikto!" - 
00:08:34     INFO - TEST-PASS | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | Second restored tab is correct - "Licenses" == "Licenses" - 
00:08:34     INFO - Buffered messages finished
00:08:34     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | Third restored tab is correct - "About About" == "New Tab" - JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_restore_reversed_z_order.js :: test_windows_are_restored_in_reversed_z_order :: line 73
00:08:34     INFO - Stack trace:
00:08:34     INFO - chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_restore_reversed_z_order.js:test_windows_are_restored_in_reversed_z_order:73
00:08:34     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
00:08:34     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
00:08:34     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:999
00:08:34     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
00:08:34     INFO - TEST-PASS | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | Last restored tab should be a minimized window - "The Book of Mozilla, 11:14" == "The Book of Mozilla, 11:14" - 
00:08:34     INFO - Leaving test bound test_windows_are_restored_in_reversed_z_order
00:08:34     INFO - GECKO(2144) | MEMORY STAT | vsize 4769MB | residentFast 702MB | heapAllocated 310MB
00:08:34     INFO - TEST-OK | browser/components/sessionstore/test/browser_restore_reversed_z_order.js | took 5082ms
Flags: needinfo?(mdeboer)
Whiteboard: [stockwell needswork]
Attached patch Disable on multiple platforms (obsolete) — Splinter Review
Attachment #9003108 - Flags: review?(jmaher)
Comment on attachment 9003108 [details] [diff] [review]
Disable on multiple platforms

Review of attachment 9003108 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/test/browser.ini
@@ +286,4 @@
>  [browser_speculative_connect.js]
>  [browser_1446343-windowsize.js]
>  [browser_restore_reversed_z_order.js]
> +skip-if = (os == 'linux') || (os == 'mac') || (os == 'win' && os_version == '10.0' && debug) #Bug 1455602

I would just put:
skip-if = true # Bug 1455602

we have some win7 failures as well, so why not disable it 100%
Attachment #9003108 - Flags: review?(jmaher) → review-
Made the changes.
Attachment #9003108 - Attachment is obsolete: true
Attachment #9003135 - Flags: review?(jmaher)
Attachment #9003135 - Flags: review?(jmaher) → review+
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b80407ff63a9
Disable browser/components/sessionstore/test/browser_restore_reversed_z_order.js for frequent failures. r=jmaher
Keywords: checkin-needed
Flags: needinfo?(mdeboer)
You need to log in before you can comment on or make changes to this bug.