1455624 - Installation is failing with Failed to remove temporary file: 0x80520015

Status: UNCONFIRMED

(Toolkit :: Add-ons Manager, defect)

Description

[Md Rahatur Rahman]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180409184545

Steps to reproduce:

Download the xpi file from addon manager and host the xpi file on a private server.
On your web page use the inline installer API to install the Addon from the hosted URL.


Actual results:

When we install the Addon from the browser, the first time there is no error. Tho, before the Addon is installed there is a prompt that says "Firefox prevented this site from asking you to install software...". When I allow the Addon it installs properly.

But after the Addon is removed and installed again it logs the following errors in the browser's console:

    1523369438217 addons.xpi WARN Failed to remove temporary file C:\Users...\AppData\Local\Temp\tmp-7i8.xpi for addon https://www........com/BrowserExtensions/FF/pulselinks_window_launch-1.0-fx-windows.xpi: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: resource://gre/modules/addons/XPIInstall.jsm :: removeTemporaryFile :: line 1493" data: no] Stack trace: removeTemporaryFile()@resource://gre/modules/addons/XPIInstall.jsm:1493 startInstall/<()@resource://gre/modules/addons/XPIInstall.jsm:1845



Expected results:

Should have got installed every time without any error.

Comment 1

[Andre Klapper]

What is "the addon" or "the xpi"? Steps to reproduce needed.
https://addons.mozilla.org/en-US/firefox/addon/pulselinks-window-launch/ does not exist (anymore).

Comment 2

[Md Rahatur Rahman]

Here are the steps I followed to create the xpi file:
# Zip the contents of the plugin folder. Did not the root folder but the contents
# Then go to the MDN Dashboard and login
# Click the ‘MY ADD-ONS’ link from the menu
# Click the title of the Addon you want to update. This will open the Addon detail page
# From the left Menu click the ‘Manage Status & Versions’
# Click the ‘Upload a new Version’ button
# Click ‘Select a file’ and then click the ‘Sign Add-on’ button
# If there is no error then you will have the platform selection option on the page. Select Windows, Linus and Mac OS X
# On the following page select ‘On your own’ and click ‘Continue’
# Download the signed xpi file and upload to the FTP location where we have the Firefox addones

Here is the code to install the xpi file:

var xpiUrl = "https://www.pulselinks.com/BrowserExtensions/FF/pulselinks_window_launch-1.0-fx-windows.xpi";
var xpi = { 'XPInstall Pre-Checkin Test': xpiUrl };
InstallTrigger.install(xpi, function () { });

Comment 3

[Abe - QA (:Abe_LV)]

Hi Md Rahatur,
 
I tested this on the latest nightly by installing the addon from the xpiURL provided in comment 2. It gets installed without error.
Screen capture- https://testing-1.tinytake.com/sf/MjU0ODc0OF83NjYzMTc4
 
Do you have any other addons installed? If yes, could you please provide your about:support page as attachment?

Thanks

Comment 4

[Md Rahatur Rahman]

(In reply to Abe - QA (:Abe_LV) from comment #3)
> Hi Md Rahatur,
>  
> I tested this on the latest nightly by installing the addon from the xpiURL
> provided in comment 2. It gets installed without error.
> Screen capture- https://testing-1.tinytake.com/sf/MjU0ODc0OF83NjYzMTc4
>  
> Do you have any other addons installed? If yes, could you please provide
> your about:support page as attachment?
> 
> Thanks

Hi Abe,
How did you install the Addon?

It also installs on my machine if installed manually.
But we are installing using the MDN Install API on a page as pointed out in comment 2.
Another person was able to reproduce the issue as reported: https://stackoverflow.com/questions/49757241/ns-error-file-access-denied-error-when-firefox-addon-is-installed-the-second-tim

Comment 5

[Paul Heil]

I can reproduce this error with 60.0b15.  Though maybe it's an OS issue since I have over 100 "tmp-XXX.xpi" files in my temp path.  I am using Windows 7 Enterprise SP1 (x64)

Comment 6

[Md Rahatur Rahman]

(In reply to Paul Heil from comment #5)
> I can reproduce this error with 60.0b15.  Though maybe it's an OS issue
> since I have over 100 "tmp-XXX.xpi" files in my temp path.  I am using
> Windows 7 Enterprise SP1 (x64)

I also tried emptying the temp folders on windows 7 and 10 machines. No result.

Comment 7

[Ed]

I get a tmp-XXX.xpi file in my temp folder for every addon update on FF Release and Beta - but never for Nightly.  I am using Windows 7 Pro SP1 x64. Same errors in the console as the OP.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Can you still reproduce this bug?

Comment 9

[Ed]

I'm still seeing some tmp-XXX.xpi files in my temp folder for all versions, but nowhere near as many. Also, I just noticed one while updating but it disappeared quickly.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.