1455952 - Recent Highlights ignore browser.tabs.loadBookmarksInTabs

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[Yuri Khan]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180414155147

Steps to reproduce:

From a clean profile:

1. In about:config, set browser.tabs.loadBookmarksInTabs to true. (Keep the about:config tab open and current.)
2. Click the Library button on the toolbar.
3. Observe that the bottom half of the popup contains the Recent Highlights section with a few bookmarks.
4. Click any of the bookmarks in Recent Highlights.


Actual results:

The bookmarked page replaces about:config in the current tab.


Expected results:

The bookmark should open in a new tab, respecting the browser.tabs.loadBookmarksInTabs setting.


I am not sufficiently bothered by this bug to propose a fix; if anyone is interested, the relevant code is here:

https://searchfox.org/mozilla-central/search?q=onLibraryHighlightClick

The general handling of loadBookmarksInTabs is here:

https://searchfox.org/mozilla-central/search?q=openNodeWithEvent

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
20180422100125

(In reply to Yuri Khan from comment #0)
> I am not sufficiently bothered by this bug to propose a fix; if anyone is
> interested, the relevant code is here:
> 
> https://searchfox.org/mozilla-central/search?q=onLibraryHighlightClick

Bug 1422299