Closed
Bug 1456076
Opened 6 years ago
Closed 6 years ago
Update ESLint to 4.19.1 & eslint-plugin-html to 4.0.3
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P2)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
ESlint 4.19.1 is likely to be the last of the 4.x series. 5.0 is currently in alpha. 4.19.1 brings some slightly better regexp testing which causes failures for us, so it'd be nice to get those resolved & upgraded to the latest ESLint before we hit 5.x.
Assignee | ||
Comment 1•6 years ago
|
||
Also eslint-plugin-html has a compatibility fix for working with other plugins. I don't think it affects us, but it is safe to take anyway.
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8970126 [details] Bug 1456076 - Update ESLint to 4.19.1 & eslint-plugin-html to 4.0.3. https://reviewboard.mozilla.org/r/238924/#review245886
Attachment #8970126 -
Flags: review?(dtownsend) → review+
Comment 4•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 8e3e4bf2c192d97a4be6e6ee98b6994bb56f33a0 -d 94d0e43dad11: rebasing 460649:8e3e4bf2c192 "Bug 1456076 - Update ESLint to 4.19.1 & eslint-plugin-html to 4.0.3. r=mossop" (tip) merging npm-shrinkwrap.json merging tools/lint/eslint/eslint-plugin-mozilla/package-lock.json merging tools/lint/eslint/eslint-plugin-mozilla/package.json warning: conflicts while merging npm-shrinkwrap.json! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e065d127de0 Update ESLint to 4.19.1 & eslint-plugin-html to 4.0.3. r=mossop
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6e065d127de0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•5 years ago
|
Version: Version 3 → 3 Branch
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•