1456085 - Increase ESLint's minimum node & npm requirements to 8.9.1 & 5.5.1 respectively

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement, P2)

Description

[Mark Banner (:standard8)]

Per bug 1456078, the minimum node version is being increased to v6.14.0 for the next major ESLint update. Currently we require v6.9.1.

I think we should bump the node version, and also go up to a minimum of 8.9.1:

* MozillaBuild & our automation already use node 8.9.1
* A lot has changed in npm between 3.10.x and 5.5.x, upgrading the minimum will provide better consistency for developers, especially with respect to npm-shrinkwrap.json
* node 8.9.1 ships with npm 5.5.1
* This brings us closer to what was suggested in the "Intent to require Node..." thread on dev-platform a while ago.

Comment 1

[Mark Banner (:standard8)]

I've just sent email to firefox-dev & dev-platform for this. Will put a comment in the Firefox fortnightly meeting notes as well.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1456085 - Increase ESLint's minimum node & npm requirements to 8.9.1 & 5.5.1 respectively.

Also use package-lock.json rather than npm-shrinkwrap.json as we no longer need to support the latter.

Review commit: https://reviewboard.mozilla.org/r/242296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242296/

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8973960 [details]
Bug 1456085 - Increase ESLint's minimum node & npm requirements to 8.9.1 & 5.5.1 respectively.

https://reviewboard.mozilla.org/r/242296/#review248184

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7048b011cc74
Increase ESLint's minimum node & npm requirements to 8.9.1 & 5.5.1 respectively. r=ahal

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7048b011cc74