Closed Bug 1456085 Opened 2 years ago Closed 2 years ago

Increase ESLint's minimum node & npm requirements to 8.9.1 & 5.5.1 respectively

Categories

(Firefox Build System :: Lint and Formatting, enhancement, P2)

3 Branch
enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Per bug 1456078, the minimum node version is being increased to v6.14.0 for the next major ESLint update. Currently we require v6.9.1.

I think we should bump the node version, and also go up to a minimum of 8.9.1:

* MozillaBuild & our automation already use node 8.9.1
* A lot has changed in npm between 3.10.x and 5.5.x, upgrading the minimum will provide better consistency for developers, especially with respect to npm-shrinkwrap.json
* node 8.9.1 ships with npm 5.5.1
* This brings us closer to what was suggested in the "Intent to require Node..." thread on dev-platform a while ago.
I've just sent email to firefox-dev & dev-platform for this. Will put a comment in the Firefox fortnightly meeting notes as well.
Priority: -- → P2
Comment on attachment 8973960 [details]
Bug 1456085 - Increase ESLint's minimum node & npm requirements to 8.9.1 & 5.5.1 respectively.

https://reviewboard.mozilla.org/r/242296/#review248184
Attachment #8973960 - Flags: review?(ahalberstadt) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7048b011cc74
Increase ESLint's minimum node & npm requirements to 8.9.1 & 5.5.1 respectively. r=ahal
https://hg.mozilla.org/mozilla-central/rev/7048b011cc74
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.