1456110 - Hide Notification settings entry when aimless

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, enhancement, P5)

Description

[Petru-Mugurel Lingurar [:petru]]

Based on user report - bug 1455814 this entry in Settings should be hidden if it is of no use.

Right now, it houses just one setting for the "whatsnew-notification" experiment which according to SwitchBoard is effectively available to no-one.

To avoid future confusions I think it would be helpful to remove this entry altogether from Settings when not needed.

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1456110 - 1. Hide "what's new" notification settings if not in experiement; r?sdaswani

The "What's new" notification (bug 1004734) is based on an experiment which
currently is available to noone.
To avoid any confusions the settings entry for it will be hidden if the user
is not in an active "What's new" experiment.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1456110 - 2. Hide Notification settings if not actionable; r?sdaswani

Currently the Notification settings screen lets the user enable/disable
two types of notifications, both depending on Switchboard experiments.
If none of those experiments are available for the user, the entire settings
group will be hidden to avoid any confusion.

Depends on D5854

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9009074 [details]
Bug 1456110 - 1. Hide "what's new" notification settings if not in experiement; r?sdaswani

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9009075 [details]
Bug 1456110 - 2. Hide Notification settings if not actionable; r?sdaswani

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28443e4a57fb
1. Hide "what's new" notification settings if not in experiement; r=jchen

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88cfcf384ffa
2. Hide Notification settings if not actionable; r=jchen

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71216f09ae26
Backed out 2 changesets for android-checkstyle failure on a CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b074e28cbaec
1. Hide "what's new" notification settings if not in experiement. r=jchen
https://hg.mozilla.org/integration/autoland/rev/6120e8aa1e3b
2. Hide Notification settings if not actionable. r=jchen

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on testSettingsPages related to notifications

backout:  https://hg.mozilla.org/integration/autoland/rev/84966ece97c0134c95d23a299a5dad25d782b1e4

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6120e8aa1e3b47682c12a52126a1c079a25e86de&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199701250&repo=autoland&lineNumber=1729


[task 2018-09-17T15:43:54.313Z] 15:43:54     INFO -  waitForText timeout on ^Notifications$
[task 2018-09-17T15:43:54.314Z] 15:43:54     INFO -  Buffered messages logged at 15:43:04
[task 2018-09-17T15:43:54.314Z] 15:43:54     INFO -  waitForPreferencesText scrolled down
[task 2018-09-17T15:43:54.314Z] 15:43:54     INFO -  Buffered messages logged at 15:43:28
[task 2018-09-17T15:43:54.315Z] 15:43:54     INFO -  waitForPreferencesText scrolled up
[task 2018-09-17T15:43:54.315Z] 15:43:54     INFO -  Buffered messages finished
[task 2018-09-17T15:43:54.316Z] 15:43:54  WARNING -  TEST-UNEXPECTED-FAIL | testSettingsPages | Waiting for and scrolling once to find section ^Notifications$ - ^Notifications$ found
[task 2018-09-17T15:43:54.316Z] 15:43:54     INFO -  0 ERROR Exception caught during test! - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testSettingsPages | Waiting for and scrolling once to find section ^Notifications$ - ^Notifications$ found
[task 2018-09-17T15:43:54.317Z] 15:43:54     INFO -  	at junit.framework.Assert.fail(Assert.java:50)
[task 2018-09-17T15:43:54.317Z] 15:43:54     INFO -  	at org.mozilla.gecko.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:124)
[task 2018-09-17T15:43:54.318Z] 15:43:54     INFO -  	at org.mozilla.gecko.FennecMochitestAssert.ok(FennecMochitestAssert.java:145)
[task 2018-09-17T15:43:54.318Z] 15:43:54     INFO -  	at org.mozilla.gecko.tests.testSettingsPages.selectSettingsSection(testSettingsPages.java:97)
[task 2018-09-17T15:43:54.318Z] 15:43:54     INFO -  	at org.mozilla.gecko.tests.testSettingsPages.testNotificationsSection(testSettingsPages.java:64)
[task 2018-09-17T15:43:54.319Z] 15:43:54     INFO -  	at org.mozilla.gecko.tests.testSettingsPages.testSettingsPages(testSettingsPages.java:27)
[task 2018-09-17T15:43:54.319Z] 15:43:54     INFO -  	at java.lang.reflect.Method.invokeNative(Native Method)
[task 2018-09-17T15:43:54.320Z] 15:43:54     INFO -  	at java.lang.reflect.Method.invoke(Method.java:525)
[task 2018-09-17T15:43:54.320Z] 15:43:54     INFO -  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
[task 2018-09-17T15:43:54.320Z] 15:43:54     INFO -  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
[task 2018-09-17T15:43:54.321Z] 15:43:54     INFO -  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
[task 2018-09-17T15:43:54.321Z] 15:43:54     INFO -  	at org.mozilla.gecko.tests.BaseRobocopTest.runTest(BaseRobocopTest.java:188)
[task 2018-09-17T15:43:54.322Z] 15:43:54     INFO -  	at junit.framework.TestCase.runBare(TestCase.java:134)
[task 2018-09-17T15:43:54.322Z] 15:43:54     INFO -  	at junit.framework.TestResult$1.protect(TestResult.java:115)
[task 2018-09-17T15:43:54.323Z] 15:43:54     INFO -  	at junit.framework.TestResult.runProtected(TestResult.java:133)
[task 2018-09-17T15:43:54.323Z] 15:43:54     INFO -  	at junit.framework.TestResult.run(TestResult.java:118)
[task 2018-09-17T15:43:54.323Z] 15:43:54     INFO -  	at junit.framework.TestCase.run(TestCase.java:124)
[task 2018-09-17T15:43:54.324Z] 15:43:54     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
[task 2018-09-17T15:43:54.324Z] 15:43:54     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
[task 2018-09-17T15:43:54.324Z] 15:43:54     INFO -  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
[task 2018-09-17T15:43:54.325Z] 15:43:54     INFO -  	at org.mozilla.gecko.FennecInstrumentationTestRunner.onStart(FennecInstrumentationTestRunner.java:66)
[task 2018-09-17T15:43:54.325Z] 15:43:54     INFO -  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
[task 2018-09-17T15:43:54.326Z] 15:43:54  WARNING -  TEST-UNEXPECTED-FAIL | testSettingsPages | Exception caught - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testSettingsPages | Waiting for and scrolling once to find section ^Notifications$ - ^Notifications$ found
[task 2018-09-17T15:43:54.326Z] 15:43:54     INFO -  TEST-OK | testSettingsPages | took 164858ms

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1456110 - 3. Enable the "what's new" experiment when testing; r?sdaswani

This will allow to check that indeed, when a Notifications related experiment
is enabled, the "Notifications" setting will appear in the menu.

Depends on D5855

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Sorry for this back and forth. 
Edited the test to first enable the "what's new" experiment and then check if "Notifications" appears in the settings menu.
Ran all UI tests and all seems good now - https://treeherder.mozilla.org/#/jobs?repo=try&revision=996b62a171e08e7d57c4378fb8a4fd2a0ca80856

Comment 13

[:sdaswani]

Comment on attachment 9009910 [details]
Bug 1456110 - 3. Enable the "what's new" experiment when testing; r?sdaswani

:sdaswani only needinfo has approved the revision.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a41730af09e
1. Hide "what's new" notification settings if not in experiement; r=jchen

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7939ea610132
2. Hide Notification settings if not actionable; r=jchen

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f5d431f6acb
3. Enable the "what's new" experiment when testing; r=sdaswani

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6a41730af09e
https://hg.mozilla.org/mozilla-central/rev/7939ea610132
https://hg.mozilla.org/mozilla-central/rev/6f5d431f6acb

Comment 18

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build(64.0a1 - 09/25/2018).
Devices: Sony Xperia Z5 Premium(Android 6.0.1), Google Pixel(Android 9). "Notification" section is not displayed in the Settings menu if "whatsnew-notification" is not enabled from about:experiments. And is displayed, if "whatsnew-notification" is enabled.