1456129 - HAR toolbar button should support import

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1403530.

The HAR toolbar button should also support: "Import" HAR action.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1456129 - Extend HAR toolbar with import;

Review commit: https://reviewboard.mozilla.org/r/239028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239028/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8970439 [details]
Bug 1456129 - Extend HAR toolbar with import;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239028/diff/1-2/

Comment 3

[David Walsh :davidwalsh]

Comment on attachment 8970439 [details]
Bug 1456129 - Extend HAR toolbar with import;

https://reviewboard.mozilla.org/r/239028/#review245070

Works great!  What is the use case for this though?  Is there some type of comparison tool or is it simply for auditing?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to David Walsh :davidwalsh from comment #3)
> Comment on attachment 8970439 [details]
> Bug 1456129 - Extend HAR toolbar with import;
> 
> https://reviewboard.mozilla.org/r/239028/#review245070
> 
> Works great!  What is the use case for this though?  Is there some type of
> comparison tool or is it simply for auditing?
It's intended as HAR file preview feature.

You can also drag drop HAR file onto Network panel content, but it's a bit hidden and users don't know about it. Having the feature available in the UI helps.

Thanks David for the review!

Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1618a167883
Extend HAR toolbar with import; r=davidwalsh

Comment 6

[Andreea Pavel [:apavel]]

Backed out for failing eslint at /builds/worker/checkouts/gecko/devtools/client/netmonitor/src/components/Toolbar.js:28

Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f1618a16788385f61267bf584d702e7db13c1b9a

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=175664047&repo=autoland&lineNumber=255

Backout: https://hg.mozilla.org/integration/autoland/rev/ff08a042faec4233facf5b879be7d2a95acd08c9

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8970439 [details]
Bug 1456129 - Extend HAR toolbar with import;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239028/diff/2-3/

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Sorry, both failures fixed!

Honza

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c75b36672e2a
Extend HAR toolbar with import; r=davidwalsh

Comment 10

[Andreea Pavel [:apavel]]

Backe dout for failing eslit at /builds/worker/checkouts/gecko/devtools/client/netmonitor/src/components/DropHarHandler.js:13 and clipboard at devtools/client/netmonitor/src/har/test/browser_net_har_copy_all_as_har.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4da66989752079b16519ad896cdf9267f4f17dac

Failure log:
Eslint: https://treeherder.mozilla.org/logviewer.html#?job_id=175668906&repo=autoland&lineNumber=66

Clipboard: https://treeherder.mozilla.org/logviewer.html#?job_id=175672426&repo=autoland&lineNumber=7915

Comment 11

[Andreea Pavel [:apavel]]

(In reply to Andreea Pavel [:apavel] from comment #10)
> Backe dout for failing eslit at
> /builds/worker/checkouts/gecko/devtools/client/netmonitor/src/components/
> DropHarHandler.js:13 and clipboard at
> devtools/client/netmonitor/src/har/test/browser_net_har_copy_all_as_har.js
> 
> Push with failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=4da66989752079b16519ad896cdf9267f4f17dac
> 
> Failure log:
> Eslint:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=175668906&repo=autoland&lineNumber=66
> 
> Clipboard:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=175672426&repo=autoland&lineNumber=7915

Backout: https://hg.mozilla.org/integration/autoland/rev/00e2674c6aea301e1c84d5e10f973c4d84dc03e4

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The ESlint failure occurs because bug 1456686 got merged and the now unused HARImporter gets detected.

Comment 13

[Francesco Lodolo [:flod]]

You're also failing browser/base/content/test/static/browser_misused_characters_in_strings.js

07:23:27    ERROR -  51 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_misused_characters_in_strings.js | jar:file:///Z:/task_1524726398/build/application/firefox/browser/omni.ja!/chrome/en-US/locale/en-US/devtools/client/netmonitor.properties with key=netmonitor.context.importHar has a misused ellipsis. Strings with an ellipsis should use the Unicode … character instead of three periods. -

Comment 14

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8970439 [details]
Bug 1456129 - Extend HAR toolbar with import;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239028/diff/3-4/

Comment 15

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Test failures fixed, try looks good 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=78aae9cadbaa6303aa954d2f5355b64279cb52ff

Honza

Comment 16

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8044e25d9af8367c430ad1e0b3ebeaba14993a47 -d 04ed44189998: rebasing 460631:8044e25d9af8 "Bug 1456129 - Extend HAR toolbar with import; r=davidwalsh" (tip)
other [source] changed devtools/client/netmonitor/src/har/har-menu-utils.js which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
merging devtools/client/locales/en-US/netmonitor.properties
merging devtools/client/netmonitor/src/components/App.js
merging devtools/client/netmonitor/src/components/DropHarHandler.js
merging devtools/client/netmonitor/src/components/MonitorPanel.js
merging devtools/client/netmonitor/src/components/Toolbar.js
merging devtools/client/netmonitor/src/utils/menu.js
warning: conflicts while merging devtools/client/netmonitor/src/components/Toolbar.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35223e75d84e
Extend HAR toolbar with import; r=davidwalsh

Comment 18

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/35223e75d84e