Closed Bug 1456213 Opened 7 years ago Closed 7 years ago

Make firefoxtree compatible with Mercurial 4.6

Categories

(Developer Services :: Mercurial: firefoxtree, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(5 files)

No description provided.
This enables the firefoxtree extension to load with Mercurial 4.6.
Comment on attachment 8971611 [details] firefoxtree: look for renamed wire protocol module (bug 1456213); r?sheehan Connor Sheehan [:sheehan] has approved the revision. https://phabricator.services.mozilla.com/D1020
Attachment #8971611 - Flags: review+
This avoids a deprecation warning on Mercurial 4.6.
Comment on attachment 8971614 [details] firefoxtree: use logcmdutil.changesetdisplayer if available (bug 1456213); r?sheehan Connor Sheehan [:sheehan] has approved the revision. https://phabricator.services.mozilla.com/D1021
Attachment #8971614 - Flags: review+
Mercurial 4.6 moved permissions declaration into the @wireprotocommand decorator. This commit sniffs for and uses that argument, if available. This unbusts the wire protocol command on Mercurial 4.6.
Comment on attachment 8971615 [details] firefoxtree: declare permissions via @wireprotocommand (bug 1456213); r?sheehan Connor Sheehan [:sheehan] has approved the revision. https://phabricator.services.mozilla.com/D1022
Attachment #8971615 - Flags: review+
util.Abort was removed in Mercurial 4.6 it appears.
Comment on attachment 8971616 [details] firefoxtree: use error.Abort (bug 1456213); r?sheehan Connor Sheehan [:sheehan] has approved the revision. https://phabricator.services.mozilla.com/D1023
Attachment #8971616 - Flags: review+
We should have done this a few months ago.
Comment on attachment 8971617 [details] firefoxtree: update version compatibility (bug 1456213); r?sheehan Connor Sheehan [:sheehan] has approved the revision. https://phabricator.services.mozilla.com/D1024
Attachment #8971617 - Flags: review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/7a334dedf70a firefoxtree: look for renamed wire protocol module ; r=sheehan
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/09390f4efba7 firefoxtree: use logcmdutil.changesetdisplayer if available ; r=sheehan https://hg.mozilla.org/hgcustom/version-control-tools/rev/a147ca9631e3 firefoxtree: declare permissions via @wireprotocommand ; r=sheehan https://hg.mozilla.org/hgcustom/version-control-tools/rev/2b4fc8d83865 firefoxtree: use error.Abort ; r=sheehan https://hg.mozilla.org/hgcustom/version-control-tools/rev/70ca4878ce66 firefoxtree: update version compatibility ; r=sheehan
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: