1456266 - ConstantsourceNode.channelCount

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[toy.raymond]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

Run

c = new AudioContext();
n = new ConstantSourceNode(c)


Actual results:

n.channelCount is 1


Expected results:

n.channelCount should be 2.

Since this is a source node, the channelCount value has no bearing on anything, but the spec says it should be 2.

Comment 1

[Alex Chronopoulos [:achronop]]

We hard code to 1 [1] according to the spec that should be 2.

[1] https://searchfox.org/mozilla-central/source/dom/media/webaudio/ConstantSourceNode.cpp#149
[2] https://webaudio.github.io/web-audio-api/#ConstantSourceNode

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1456266 - In ConstantSourceNode change the default channelCount to align with the spec.

Review commit: https://reviewboard.mozilla.org/r/240036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240036/

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8971268 [details]
Bug 1456266 - In ConstantSourceNode change the default channelCount to align with the spec.

https://reviewboard.mozilla.org/r/240036/#review245804

Comment 4

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=500cbd125e15ff0c847d4059675d23a16a640c22

Comment 5

[Alex Chronopoulos [:achronop]]

Comment on attachment 8971268 [details]
Bug 1456266 - In ConstantSourceNode change the default channelCount to align with the spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240036/diff/1-2/

Comment 6

[Mozilla Autoland]

hg error in cmd: hg pull upstream: pulling from https://hg.mozilla.org/integration/autoland
searching for changes
abort: HTTP Error 500: Internal Server Error

Comment 7

[Mozilla Autoland]

hg error in cmd: hg pull upstream: pulling from https://hg.mozilla.org/integration/autoland
searching for changes
abort: HTTP Error 500: Internal Server Error

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1271b4411efd
In ConstantSourceNode change the default channelCount to align with the spec. r=padenot

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1271b4411efd