Closed Bug 1456266 Opened Last year Closed Last year

ConstantsourceNode.channelCount

Categories

(Core :: Web Audio, defect, P2)

57 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: toy.raymond, Assigned: achronop)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

Run

c = new AudioContext();
n = new ConstantSourceNode(c)


Actual results:

n.channelCount is 1


Expected results:

n.channelCount should be 2.

Since this is a source node, the channelCount value has no bearing on anything, but the spec says it should be 2.
Component: Untriaged → Web Audio
Product: Firefox → Core
Rank: 15
Priority: -- → P2
See Also: → 1443224
We hard code to 1 [1] according to the spec that should be 2.

[1] https://searchfox.org/mozilla-central/source/dom/media/webaudio/ConstantSourceNode.cpp#149
[2] https://webaudio.github.io/web-audio-api/#ConstantSourceNode
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8971268 [details]
Bug 1456266 - In ConstantSourceNode change the default channelCount to align with the spec.

https://reviewboard.mozilla.org/r/240036/#review245804
Attachment #8971268 - Flags: review?(padenot) → review+
Assignee: nobody → achronop
hg error in cmd: hg pull upstream: pulling from https://hg.mozilla.org/integration/autoland
searching for changes
abort: HTTP Error 500: Internal Server Error
hg error in cmd: hg pull upstream: pulling from https://hg.mozilla.org/integration/autoland
searching for changes
abort: HTTP Error 500: Internal Server Error
Pushed by achronop@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1271b4411efd
In ConstantSourceNode change the default channelCount to align with the spec. r=padenot
https://hg.mozilla.org/mozilla-central/rev/1271b4411efd
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.