1456269 - Construct OscillatorNode with PeriodicWave fails

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[toy.raymond]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

Run

c = new AudioContext()
p = new PeriodicWave(context, {real: [1, 1]});
n0 = new OscillatorNode(context, {periodicWave: p})
n1 = new OscillatorNode(context, {type: "custom", periodicWave: p})


Actual results:

Construction of n0 works, but construction of n1 fails,


Expected results:

Construction of both n0 and n1 should work.

I'm guessing the code disallows setting the type if periodicWave is also given.  But we're setting the type to "custom", which is what the type of an OscillatorNode should be when a periodicWave is given.  Thus, I think this should work.

The spec says that type is ignored if periodicWave is specified.

Comment 1

[Valentin MILLET]

Attachment: Bug 1456269 - Construct OscillatorNode with PeriodicWave and type custom works. r?padenot

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1456269 - Remove expectations files for WPT ctor-oscillator.html.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eadff042177
Construct OscillatorNode with PeriodicWave and type custom works. r=padenot
https://hg.mozilla.org/integration/autoland/rev/3db3093b0977
Remove expectations files for WPT ctor-oscillator.html.

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6eadff042177
https://hg.mozilla.org/mozilla-central/rev/3db3093b0977