1456271 - new PeriodicWave(context) fails

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[toy.raymond]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

Run

c = new AudioContext()
n = new PeriodicWave(context)


Actual results:

Construction of the PeriodicWave fails with this error message:
IndexSizeError: Index or size is negative or greater than the allowed amount

Not sure what that really means


Expected results:

The periodicWave should have been constructed.  The spec says the options dictionary is optional, and if not given, a sine wave is constructed.

See https://webaudio.github.io/web-audio-api/#periodicwave, the note in step 3 of the construction algorithm.

Possibly related to 1324181

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1456271 - Implement new behaviour of PeriodicWave ctor: not passing in any array makes it into a sine wave.

Review commit: https://reviewboard.mozilla.org/r/247974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247974/

Comment 2

[Paul Adenot (:padenot)]

Baku, the tests are being landed in web-platform-tests.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8981958 [details]
Bug 1456271 - Implement new behaviour of PeriodicWave ctor: not passing in any array makes it into a sine wave.

https://reviewboard.mozilla.org/r/247974/#review254082

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1456271 - Ajust tests to reflect the alignment to the spec.

Review commit: https://reviewboard.mozilla.org/r/257192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257192/

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 8981958 [details]
Bug 1456271 - Implement new behaviour of PeriodicWave ctor: not passing in any array makes it into a sine wave.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247974/diff/1-2/

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8992321 [details]
Bug 1456271 - Ajust tests to reflect the alignment to the spec.

https://reviewboard.mozilla.org/r/257192/#review264004

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b37a0606d6a0
Implement new behaviour of PeriodicWave ctor: not passing in any array makes it into a sine wave. r=baku
https://hg.mozilla.org/integration/autoland/rev/b99bd4121181
Ajust WPT expectations: the idl test for PeriodicWave now passes. r=padenot

Comment 8

[Eliza Balazs [:ebalazs_]]

Backed out 2 changesets (bug 1456271) for mda failures in dom/media/webaudio/test/test_periodicWave.html

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188357744&repo=autoland&lineNumber=35663

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b99bd412118184d8b8663bdac561b5679dba1b5f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=188357744

Backout push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2613d4453b1ffcc0fde21cd4a0ed0dab08dde553&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8992321 [details]
Bug 1456271 - Ajust tests to reflect the alignment to the spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257192/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6119be43135
Implement new behaviour of PeriodicWave ctor: not passing in any array makes it into a sine wave. r=baku
https://hg.mozilla.org/integration/autoland/rev/2ce1d3526399
Ajust tests to reflect the alignment to the spec. r=padenot

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c6119be43135
https://hg.mozilla.org/mozilla-central/rev/2ce1d3526399