Closed Bug 1456326 Opened 2 years ago Closed 2 years ago

Run decision task on modern decision image

Categories

(Firefox Build System :: Task Configuration, task)

3 Branch
task
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(4 files, 1 obsolete file)

The decision task is running on a Docker image that doesn't have the latest versions of robustcheckout, run-task, etc. We should fix that.
This is currently breaking every single trypush as of about an hour ago...
I'm hoping this is the final decision docker image update where we have to deal with the docker sha allowlists.

(Cotv2 is running, and doesn't require maintaining the allowlists, but we'd need to audit to make sure that no release- or nightly- graphs require cotv1 behavior before turning off cotv1.)
The Docker image referenced in the patches is available at indygreg/decision:2.1.0 on Docker Hub (I don't have privileges to push to taskcluster/decision). Someone with privileges will need to:

  $ docker pull indygreg/decision:2.1.0
  $ docker tag 8f741a0f0a37 taskcluster/decision:2.1.0
  $ docker push taskcluster/decision:2.1.0

The scriptworker PR is at https://github.com/mozilla-releng/scriptworker/pull/207. It will need to be merged and deployed (also requires a Puppet change IIRC) before we land the .taskcluster.yml change in Firefox land.
Assignee: nobody → gps
Status: NEW → ASSIGNED
(In reply to :Gijs (he/him) from comment #1)
> This is currently breaking every single trypush as of about an hour ago...

Make noise in #taskcluster or #sheriffs. People can terminate workers that are misbehaving.

I'm still trying to figure out what triggered the problems today. Most likely someone mucking around with low-level Taskgraph things on Try pushes.
Attached patch puppet-decision (obsolete) — Splinter Review
Attachment #8970394 - Flags: review?(gps)
Comment on attachment 8970392 [details]
Bug 1456326 - Use latest decision image for decision task;

https://reviewboard.mozilla.org/r/239170/#review245006
Attachment #8970392 - Flags: review?(dustin) → review+
Comment on attachment 8970391 [details]
Bug 1456326 - Bump version of decision image;

https://reviewboard.mozilla.org/r/239168/#review245004
Attachment #8970391 - Flags: review?(dustin) → review+
Comment on attachment 8970390 [details]
Bug 1456326 - Trim some fat from decision image;

https://reviewboard.mozilla.org/r/239166/#review245002

::: taskcluster/docker/decision/Dockerfile:2
(Diff revision 1)
>  FROM          ubuntu:16.04
> -MAINTAINER    Greg Arndt <garndt@mozilla.com>
> +MAINTAINER    Dustin Mitchell <dustin@mozilla.com>

haha, I'm not sure that's an improvement!
Attachment #8970390 - Flags: review?(dustin) → review+
Attachment #8970395 - Flags: review?(gps) → review+
> [~] docker push taskcluster/decision:2.1.0
> The push refers to a repository [docker.io/taskcluster/decision]
> e7288ff64099: Mounted from indygreg/decision 
> d781b49eaf63: Mounted from indygreg/decision 
> 23bddb544bf7: Mounted from indygreg/decision 
> beb57e2e378c: Mounted from indygreg/decision 
> 1033e26254d0: Mounted from indygreg/decision 
> 49a8ecd28bc4: Mounted from indygreg/decision 
> fb97b15cbf9a: Mounted from indygreg/decision 
> e37b2b09e34f: Mounted from indygreg/decision 
> a8de0e025d94: Mounted from indygreg/decision 
> a5e66470b281: Mounted from indygreg/decision 
> ac7299292f8b: Mounted from indygreg/decision 
> e1a9a6284d0d: Mounted from indygreg/decision 
> fccbfa2912f0: Mounted from indygreg/decision 
> 2.1.0: digest: sha256:6db3b697d7a3c7aba440d72f04199331b872111cefff57206b8b8b1d53230360 size: 3024

Pushed.
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c59d86891140
Trim some fat from decision image; r=dustin
https://hg.mozilla.org/integration/autoland/rev/f006d267e9ad
Bump version of decision image; r=dustin
https://hg.mozilla.org/integration/autoland/rev/27d9c410de6a
Use latest decision image for decision task; r=dustin
Tasks on Autoland seem happy. So yay!
https://hg.mozilla.org/mozilla-central/rev/c59d86891140
https://hg.mozilla.org/mozilla-central/rev/f006d267e9ad
https://hg.mozilla.org/mozilla-central/rev/27d9c410de6a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/93a7ae55ae6e
Use latest decision image for decision task; r=me
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.