1456335 - Backups fail to run but report success

Status: RESOLVED FIXED

(Taskcluster :: Operations and Service Requests, task, P3)

Description

[Brian Stack [:bstack]]

I was just checking to see if backups succeeded the last time they ran because I am about to use terraform on that account. When I checked, the task [0] had "succeeded" but the log was filled with scope errors.

```
Failed to get access to sentry, err: Error: You do not have sufficient scopes. You are missing the following scopes:
auth:sentry:taskcluster-backup
You have the scopes:
[
  "auth:aws-s3:read-write:taskcluster-backups/",
  "auth:azure-container:list-containers:*",
  "auth:azure-container:read-only:*",
  "auth:azure-table:list-accounts",
  "auth:azure-table:list-tables:*",
  "auth:azure-table:read-only:*",
  "auth:sentry:taskcluster-backups",
  "auth:statsum:taskcluster-backups",
  "queue:create-artifact:ZzYsBvGLQruGCXlzlrj8aQ/0",
  "queue:reclaim-task:ZzYsBvGLQruGCXlzlrj8aQ/0",
  "queue:resolve-task:ZzYsBvGLQruGCXlzlrj8aQ/0"
]
This request requires you to satisfy this scope expression:
auth:sentry:taskcluster-backup
----
method:     sentryDSN
errorCode:  InsufficientScopes
statusCode: 403
time:       2018-04-23T17:32:49.273Z
    at /taskcluster-backup/node_modules/taskcluster-client/lib/client.js:333:21
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:228:7), jsoN: {"body":{"code":"InsufficientScopes","message":"You do not have sufficient scopes. You are missing the following scopes:\n\nauth:sentry:taskcluster-backup\n\nYou have the scopes:\n\n[\n  \"auth:aws-s3:read-write:taskcluster-backups/\",\n  \"auth:azure-container:list-containers:*\",\n  \"auth:azure-container:read-only:*\",\n  \"auth:azure-table:list-accounts\",\n  \"auth:azure-table:list-tables:*\",\n  \"auth:azure-table:read-only:*\",\n  \"auth:sentry:taskcluster-backups\",\n  \"auth:statsum:taskcluster-backups\",\n  \"queue:create-artifact:ZzYsBvGLQruGCXlzlrj8aQ/0\",\n  \"queue:reclaim-task:ZzYsBvGLQruGCXlzlrj8aQ/0\",\n  \"queue:resolve-task:ZzYsBvGLQruGCXlzlrj8aQ/0\"\n]\n\nThis request requires you to satisfy this scope expression:\n\nauth:sentry:taskcluster-backup\n----\nmethod:     sentryDSN\nerrorCode:  InsufficientScopes\nstatusCode: 403\ntime:       2018-04-23T17:32:49.273Z","requestInfo":{"method":"sentryDSN","params":{"project":"taskcluster-backup"},"payload":{},"time":"2018-04-23T17:32:49.273Z"}},"code":"InsufficientScopes","statusCode":403}
Can't report to sentry, error not reported:  Error: You do not have sufficient scopes. You are missing the following scopes:
auth:statsum:taskcluster-backup
You have the scopes:
[
  "auth:aws-s3:read-write:taskcluster-backups/",
  "auth:azure-container:list-containers:*",
  "auth:azure-container:read-only:*",
  "auth:azure-table:list-accounts",
  "auth:azure-table:list-tables:*",
  "auth:azure-table:read-only:*",
  "auth:sentry:taskcluster-backups",
  "auth:statsum:taskcluster-backups",
  "queue:create-artifact:ZzYsBvGLQruGCXlzlrj8aQ/0",
  "queue:reclaim-task:ZzYsBvGLQruGCXlzlrj8aQ/0",
  "queue:resolve-task:ZzYsBvGLQruGCXlzlrj8aQ/0"
]

```

[0] https://tools.taskcluster.net/groups/ZzYsBvGLQruGCXlzlrj8aQ/tasks/ZzYsBvGLQruGCXlzlrj8aQ/runs/0/logs/public%2Flogs%2Flive.log

Comment 1

[Brian Stack [:bstack]]

Ah, now I see that this is just a minor issue. It is just missing the scopes to report to statsum and sentry which creates quite a spew of errors but everything else is probably working fine.


This was a minor typo in [1]. I believe I have fixed it by landing a 1-char patch directly into master in [2]. Please yell at me and roll this back if undesired. I have triggered a backup run and will reopen at a lower priority if it still spews.

[1] https://github.com/taskcluster/taskcluster-backup/commit/5ad357f521ae0b11cb170299a7423a6b333f0714
[2] https://github.com/taskcluster/taskcluster-backup/commit/14115c35446e86490170ddd049ed2e508693a176

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I dislike that the repo is `taskcluster-backup` but the services are named `taskcluster-backups`.  It's possible to rename in sentry.  Can we name it all `taskcluster-backup` instead?

I think I tried to do this, but forgot to change the scopes.