1456350 - Forward WebRender error! to gfxCriticalNote when GPU process does not exist

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

when GPU process does not exist, WebRender error! is not forwarded to gfxCriticalNote.

See Bug 1454878 Comment 2.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

We want to be able to get the messages, and this currently only applies to OS X?

Comment 2

[Sotaro Ikeda [:sotaro]]

(In reply to Milan Sreckovic [:milan] from comment #1)
> We want to be able to get the messages, and this currently only applies to
> OS X?

It applies also to linux. Linux does not use GPU process by default.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Forward webrender error log to gfxCriticalNote

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Forward webrender error log to gfxCriticalNote

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8970830 [details] [diff] [review]
patch - Forward webrender error log to gfxCriticalNote

I have no idea why WebRender needs to use glue.rs... and I'm not very familiar with logging stuff, so redirect to Bobby.

Comment 6

[Sotaro Ikeda [:sotaro]]

Because, rust log is singleton. If gpu process does not exist, the rust log is already initialized by Servo_Initialize().
  https://dxr.mozilla.org/mozilla-central/source/servo/ports/geckolib/glue.rs#187

And we want to forward webrender related "error!"s to gfxCriticalNote.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

It might be desirable to patch log/env_logger so that it allows having multiple instances active. It seems pretty icky to have webrender/gfx specific code in the stylo init codepath.

Comment 8

[Bobby Holley (:bholley)]

Comment on attachment 8970830 [details] [diff] [review]
patch - Forward webrender error log to gfxCriticalNote

Review of attachment 8970830 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like we should replace the Servo_Init/Servo_Shutdown with GkRust_Init/GkRust_Shutdown functions in source/toolkit/library/rust/shared/lib.rs. Those functions would do any general Gecko setup and then invoke any necessary servo code (directly, without any extra FFI calls).

Comment 9

[Sotaro Ikeda [:sotaro]]

Thanks for the advice! I am going to add GkRust_Init/GkRust_Shutdown.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Forward webrender error log to gfxCriticalNote

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Forward webrender error log to gfxCriticalNote

Update nits.

Comment 12

[Sotaro Ikeda [:sotaro]]

attachment 8971104 [details] [diff] [review] addressed the comment.

Comment 13

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8971104 [details] [diff] [review]
patch - Forward webrender error log to gfxCriticalNote

:bholley, can you review the patch again?

Comment 14

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a30a7b7d32a3fb16c264e863481a1d2899c4f689

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56a2a8cc35fd
Forward webrender error log to gfxCriticalNote r=bholley

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/56a2a8cc35fd