1456381 - [TSF] When committing composition in TSF mode, redundant "input" event is fired immediately before "composiitonend"

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Only in TSF mode, we dispatches "input" event immediately before "compositionend" event. This is a bug of TSFTextStore. TSFTextStore dispatches eCompositionChange event immediately before dispatching eCompositionCommit event since OnUpdateComposiiton() is called before OnEndComposition() and it causes creating incomplete pending composition update action.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d702a5be7826fc86762ce6cf7482a10f2f8fc0e

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1456381 - TSFTextStore should discard pending composition update actions before recording composition end action

TSFTextStore should discard pending composition update actions when it records
end composition update action because end composition update action causes
dispatching eCompositionCommit event and it replaces old composition string
anyway.  So, following eCompositionChange which is dispatched by preceding
composition update actions are just redundant.

Review commit: https://reviewboard.mozilla.org/r/239208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239208/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8970443 [details]
Bug 1456381 - TSFTextStore should discard pending composition update actions before recording composition end action

https://reviewboard.mozilla.org/r/239208/#review245224

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09928d75cfec
TSFTextStore should discard pending composition update actions before recording composition end action r=m_kato

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/09928d75cfec