Closed Bug 1456381 Opened 2 years ago Closed 2 years ago

[TSF] When committing composition in TSF mode, redundant "input" event is fired immediately before "composiitonend"

Categories

(Core :: Widget: Win32, enhancement)

All
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

(Keywords: inputmethod)

Attachments

(1 file)

Only in TSF mode, we dispatches "input" event immediately before "compositionend" event. This is a bug of TSFTextStore. TSFTextStore dispatches eCompositionChange event immediately before dispatching eCompositionCommit event since OnUpdateComposiiton() is called before OnEndComposition() and it causes creating incomplete pending composition update action.
OS: Unspecified → Windows
Hardware: Unspecified → All
Comment on attachment 8970443 [details]
Bug 1456381 - TSFTextStore should discard pending composition update actions before recording composition end action

https://reviewboard.mozilla.org/r/239208/#review245224
Attachment #8970443 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/09928d75cfec
TSFTextStore should discard pending composition update actions before recording composition end action r=m_kato
https://hg.mozilla.org/mozilla-central/rev/09928d75cfec
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1462257
You need to log in before you can comment on or make changes to this bug.