Closed
Bug 1456399
Opened 3 years ago
Closed 3 years ago
Enable LUL stack walker for Android/x86
Categories
(Core :: Gecko Profiler, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla62
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
1.31 KB,
patch
|
jseward
:
review+
|
Details | Diff | Splinter Review |
Android/x86 doesn't define USE_LUL_STACKWALK...
Comment 1•3 years ago
|
||
Is this still true? https://searchfox.org/mozilla-central/rev/ce86c6c0472d5021ef693cf99abaaa0644c89e55/tools/profiler/core/platform.cpp#118
Flags: needinfo?(m_kato)
Priority: -- → P1
Comment 2•3 years ago
|
||
Oh sorry, you said android *x86*, which uses GP_PLAT_x86_android.
Flags: needinfo?(m_kato)
Updated•3 years ago
|
Priority: P1 → P3
Assignee | ||
Comment 3•3 years ago
|
||
Assignee: nobody → m_kato
Assignee | ||
Updated•3 years ago
|
Attachment #8981091 -
Attachment is obsolete: true
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Attachment #8981092 -
Flags: review?(jseward)
Assignee | ||
Comment 5•3 years ago
|
||
tested on android emulator.
Comment 6•3 years ago
|
||
Comment on attachment 8981092 [details] [diff] [review] Enable LUL stack walker for Android/x86 Looks OK to me.
Attachment #8981092 -
Flags: review?(jseward) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/197e13dd04ab Enable LUL stack walker for Android/x86. r=jseward
Comment 8•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/197e13dd04ab
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•