1456416 - [BinAST] We seem to create our scope too late for EagerGetter/EagerSetter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[David Teller [:Yoric] - still alive but not very active]

THis shows up in https://github.com/binast/binjs-ref/issues/100 .

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1456416 - Make EagerGetter/EagerSetter create their scope earlier;

Review commit: https://reviewboard.mozilla.org/r/239246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239246/

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1456416 - Unit tests for multipart parser;

Review commit: https://reviewboard.mozilla.org/r/239268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239268/

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1456416 - Make EagerGetter/EagerSetter create their scope earlier;

Review commit: https://reviewboard.mozilla.org/r/239270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239270/

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8970499 [details]
Bug 1456416 - Unit tests for multipart parser;

https://reviewboard.mozilla.org/r/239268/#review245214

Comment 5

[Tooru Fujisawa [:arai]]

Comment on attachment 8970500 [details]
Bug 1456416 - Make EagerGetter/EagerSetter create their scope earlier;

https://reviewboard.mozilla.org/r/239270/#review245216

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8970499 [details]
Bug 1456416 - Unit tests for multipart parser;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239268/diff/1-2/

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8970500 [details]
Bug 1456416 - Make EagerGetter/EagerSetter create their scope earlier;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239270/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26dd1f51eaf4
Unit tests for multipart parser;r=arai
https://hg.mozilla.org/integration/autoland/rev/93311fa85762
Make EagerGetter/EagerSetter create their scope earlier;r=arai

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/26dd1f51eaf4
https://hg.mozilla.org/mozilla-central/rev/93311fa85762