1456481 - Permanent failure line 'ImportError: cannot import name main' for wpt when /service-workers/service-worker/worker-interception-redirect.https.html runs

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Log example: https://treeherder.mozilla.org/logviewer.html#?job_id=174856279&repo=mozilla-inbound&lineNumber=5399

[task 2018-04-20T21:55:08.018Z] 21:55:08     INFO - TEST-START | /service-workers/service-worker/worker-interception-redirect.https.html
[task 2018-04-20T21:55:08.289Z] 21:55:08  WARNING - cannot import name main
[task 2018-04-20T21:55:08.289Z] 21:55:08  WARNING - Traceback (most recent call last):
[task 2018-04-20T21:55:08.289Z] 21:55:08  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/server.py", line 256, in handle_one_request
[task 2018-04-20T21:55:08.289Z] 21:55:08  WARNING -     handler(request, response)
[task 2018-04-20T21:55:08.290Z] 21:55:08  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 240, in __call__
[task 2018-04-20T21:55:08.290Z] 21:55:08  WARNING -     execfile(path, environ, environ)
[task 2018-04-20T21:55:08.290Z] 21:55:08  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/service-workers/service-worker/resources/scope1/redirect.py", line 5, in <module>
[task 2018-04-20T21:55:08.290Z] 21:55:08  WARNING -     from redirect import main
[task 2018-04-20T21:55:08.291Z] 21:55:08  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/service-workers/service-worker/resources/scope1/redirect.py", line 5, in <module>
[task 2018-04-20T21:55:08.291Z] 21:55:08  WARNING -     from redirect import main
[task 2018-04-20T21:55:08.292Z] 21:55:08  WARNING - ImportError: cannot import name main

Comment 2

[Marion Daly [:mdaly]]

Ben: on your radar

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Python issue afaict, so redirecting to James.

Comment 4

[James Graham [:jgraham]]

Attachment: Bug 1456481 - Fix parent module import in serviceworker tests,

The previous setup was altering sys.path in the wrong way and falling
foul of the module cache. It's easier just to import the parent module
using the underlying import functions directly than try to fix up the
paths.

Review commit: https://reviewboard.mozilla.org/r/239388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239388/

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8970645 [details]
Bug 1456481 - Fix parent module import in serviceworker tests,

https://reviewboard.mozilla.org/r/239388/#review245134

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc95f676ecde
Fix parent module import in serviceworker tests, r=bkelly

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10616 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bc95f676ecde

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged