1456515 - Make blocklist plugin URL methods async

Status: RESOLVED FIXED

(Toolkit :: Blocklist Implementation, enhancement, P1)

Description

[:Gijs (away/busy until Mar 10)]

After bug 1456171 these are the last APIs remaining that aren't already async.

Comment 1

[:Gijs (away/busy until Mar 10)]

Looks like half the consumers are setting some kind of 'detailsLink' property on plugin info, which is unused since bug 1398972...

Comment 2

[:Gijs (away/busy until Mar 10)]

Attachment: Bug 1456515 - make plugin URL methods async,

Review commit: https://reviewboard.mozilla.org/r/240368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240368/

Comment 3

[:Gijs (away/busy until Mar 10)]

Comment on attachment 8971598 [details]
Bug 1456515 - make plugin URL methods async,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240368/diff/1-2/

Comment 4

[:Gijs (away/busy until Mar 10)]

Comment on attachment 8971598 [details]
Bug 1456515 - make plugin URL methods async,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240368/diff/2-3/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8971598 [details]
Bug 1456515 - make plugin URL methods async,

https://reviewboard.mozilla.org/r/240368/#review246222

Thanks

::: toolkit/mozapps/extensions/Blocklist.jsm:1270
(Diff revision 3)
>  
>      let r = this._getPluginBlocklistEntry(plugin, this._pluginEntries);
>      if (!r) {
>        return null;
>      }
>      let {entry: blockEntry} = r;

This destructuring is... weird. Can we just make this `let blockEntry = r.entry;`?

Comment 6

[:Gijs (away/busy until Mar 10)]

Comment on attachment 8971598 [details]
Bug 1456515 - make plugin URL methods async,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240368/diff/3-4/

Comment 7

[:Gijs (away/busy until Mar 10)]

Comment on attachment 8971598 [details]
Bug 1456515 - make plugin URL methods async,

https://reviewboard.mozilla.org/r/240368/#review246222

> This destructuring is... weird. Can we just make this `let blockEntry = r.entry;`?

Agreed (I just preserved this in the previous version...), and done. :-)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/537c356f4c4f
make plugin URL methods async, r=kmag

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/537c356f4c4f