Closed Bug 1456515 Opened 3 years ago Closed 3 years ago

Make blocklist plugin URL methods async

Categories

(Toolkit :: Blocklist Implementation, enhancement, P1)

Product:
Toolkit
Component:
Blocklist Implementation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [fxperf:p1])

Attachments

(1 file)

Bug 1456515 - make plugin URL methods async,
59 bytes, text/x-review-board-request
kmag
: review+
Details 
After bug 1456171 these are the last APIs remaining that aren't already async.
Priority: -- → P1
Whiteboard: [fxperf:p1]
Looks like half the consumers are setting some kind of 'detailsLink' property on plugin info, which is unused since bug 1398972...
Blocks: 1398972
Comment on attachment 8971598 [details]
Bug 1456515 - make plugin URL methods async,

https://reviewboard.mozilla.org/r/240368/#review246222

Thanks

::: toolkit/mozapps/extensions/Blocklist.jsm:1270
(Diff revision 3)
>  
>      let r = this._getPluginBlocklistEntry(plugin, this._pluginEntries);
>      if (!r) {
>        return null;
>      }
>      let {entry: blockEntry} = r;

This destructuring is... weird. Can we just make this `let blockEntry = r.entry;`?
Attachment #8971598 - Flags: review?(kmaglione+bmo) → review+
Comment on attachment 8971598 [details]
Bug 1456515 - make plugin URL methods async,

https://reviewboard.mozilla.org/r/240368/#review246222

> This destructuring is... weird. Can we just make this `let blockEntry = r.entry;`?

Agreed (I just preserved this in the previous version...), and done. :-)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/537c356f4c4f
make plugin URL methods async, r=kmag
https://hg.mozilla.org/mozilla-central/rev/537c356f4c4f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: Blocklist Policy Requests → Blocklist Implementation
You need to log in before you can comment on or make changes to this bug.