Closed
Bug 1456522
Opened 6 years ago
Closed 6 years ago
[CSD] Background tabs are unreadable in fullscreen windows on Ubuntu
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | verified |
firefox59 | --- | unaffected |
firefox60 | --- | verified |
firefox61 | --- | verified |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
stransky
:
review+
RyanVM
:
approval-mozilla-release+
|
Details |
I believe bug 1439834 broke this.
Assignee | ||
Updated•6 years ago
|
Summary: Background tabs are unreadable in fullscreen windows on Ubuntu → [CSD] Background tabs are unreadable in fullscreen windows on Ubuntu
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8970589 [details] Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. https://reviewboard.mozilla.org/r/239346/#review245244 Yes, that makes sense, Thanks!
Attachment #8970589 -
Flags: review?(stransky) → review+
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/a2d670a8074e Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. r=stransky
Comment 4•6 years ago
|
||
We may want to request uplift for 60ESR...
Assignee | ||
Updated•6 years ago
|
Flags: qe-verify+
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a2d670a8074e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8970589 [details] Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. Approval Request Comment [Feature/Bug causing the regression]: bug 1439834 [User impact if declined]: on Linux, with the title bar disabled, background tabs are unreadable in fullscreen mode [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: disable the title bar in customize mode and make the browser window fullscreen [List of other uplifts needed for the feature/fix]: / [Is the change risky?]: no [Why is the change risky/not risky?]: isolated CSS fix [String changes made/needed]: /
Attachment #8970589 -
Flags: approval-mozilla-beta?
Updated•6 years ago
|
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → affected
Comment 7•6 years ago
|
||
Comment on attachment 8970589 [details] Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. Looks like a good low-risk ride-along for the first Fx60 RC build.
Attachment #8970589 -
Flags: approval-mozilla-beta? → approval-mozilla-release+
Comment 8•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/3a1aae811a58 (FIREFOX_60b_RELBRANCH) https://hg.mozilla.org/releases/mozilla-release/rev/19a40f67957a https://hg.mozilla.org/releases/mozilla-esr60/rev/19a40f67957a
Comment 9•6 years ago
|
||
I verified this issue on Ubuntu 16.04 with FF Nightly 61.0a1(2018-04-22) and I was able to reproduce this issue. I tested with the latest Nightly 61.0a1(2018-04-29) and the issue is no longer reproducible. We will verify this also in beta after the fix will be uplifted.
Comment 10•6 years ago
|
||
This issue was also verified on Ubuntu 16.04 with FF 60.0 candidates and I wasn't able to reproduce it.
Comment 11•6 years ago
|
||
I verified this issue on FF 60.0esr build 6 with Ubuntu 16.04 and I can confirm that the issue is fixed.
You need to log in
before you can comment on or make changes to this bug.
Description
•