Closed Bug 1456522 Opened 2 years ago Closed 2 years ago

[CSD] Background tabs are unreadable in fullscreen windows on Ubuntu

Categories

(Firefox :: Theme, defect, P1)

All
Linux
defect

Tracking

()

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- verified
firefox59 --- unaffected
firefox60 --- verified
firefox61 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

I believe bug 1439834 broke this.
Summary: Background tabs are unreadable in fullscreen windows on Ubuntu → [CSD] Background tabs are unreadable in fullscreen windows on Ubuntu
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment on attachment 8970589 [details]
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode.

https://reviewboard.mozilla.org/r/239346/#review245244

Yes, that makes sense, Thanks!
Attachment #8970589 - Flags: review?(stransky) → review+
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/a2d670a8074e
Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. r=stransky
We may want to request uplift for 60ESR...
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/a2d670a8074e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment on attachment 8970589 [details]
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1439834
[User impact if declined]: on Linux, with the title bar disabled, background tabs are unreadable in fullscreen mode
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: disable the title bar in customize mode and make the browser window fullscreen
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: isolated CSS fix
[String changes made/needed]: /
Attachment #8970589 - Flags: approval-mozilla-beta?
Comment on attachment 8970589 [details]
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode.

Looks like a good low-risk ride-along for the first Fx60 RC build.
Attachment #8970589 - Flags: approval-mozilla-beta? → approval-mozilla-release+
I verified this issue on Ubuntu 16.04 with FF Nightly 61.0a1(2018-04-22) and I was able to reproduce this issue. I tested with the latest Nightly 61.0a1(2018-04-29) and the issue is no longer reproducible. 
We will verify this also in beta after the fix will be uplifted.
This issue was also verified on Ubuntu 16.04 with FF 60.0 candidates and I wasn't able to reproduce it.
I verified this issue on FF 60.0esr build 6 with Ubuntu 16.04 and I can confirm that the issue is fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.