1456522 - [CSD] Background tabs are unreadable in fullscreen windows on Ubuntu

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

I believe bug 1439834 broke this.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode.

Review commit: https://reviewboard.mozilla.org/r/239346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239346/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8970589 [details]
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode.

https://reviewboard.mozilla.org/r/239346/#review245244

Yes, that makes sense, Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2d670a8074e
Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. r=stransky

Comment 4

[Martin Stránský [:stransky] (ni? me)]

We may want to request uplift for 60ESR...

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a2d670a8074e

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8970589 [details]
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1439834
[User impact if declined]: on Linux, with the title bar disabled, background tabs are unreadable in fullscreen mode
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: disable the title bar in customize mode and make the browser window fullscreen
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: isolated CSS fix
[String changes made/needed]: /

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8970589 [details]
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode.

Looks like a good low-risk ride-along for the first Fx60 RC build.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a1aae811a58 (FIREFOX_60b_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-release/rev/19a40f67957a
https://hg.mozilla.org/releases/mozilla-esr60/rev/19a40f67957a

Comment 9

[ovidiu boca[:Ovidiu]]

I verified this issue on Ubuntu 16.04 with FF Nightly 61.0a1(2018-04-22) and I was able to reproduce this issue. I tested with the latest Nightly 61.0a1(2018-04-29) and the issue is no longer reproducible. 
We will verify this also in beta after the fix will be uplifted.

Comment 10

[ovidiu boca[:Ovidiu]]

This issue was also verified on Ubuntu 16.04 with FF 60.0 candidates and I wasn't able to reproduce it.

Comment 11

[ovidiu boca[:Ovidiu]]

I verified this issue on FF 60.0esr build 6 with Ubuntu 16.04 and I can confirm that the issue is fixed.