1456530 - Stop dispatching the select event on the tabs element

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P5)

Description

[Dão Gottwald [:dao]]

This appears to be unused and is redundant with the select event on the tabpanels element.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=721210d9508f300c148cf7ad51da9826e0e2d700

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1456530 - Stop dispatching the select event on the tabs element.

Review commit: https://reviewboard.mozilla.org/r/239350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239350/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8970592 [details]
Bug 1456530 - Stop dispatching the select event on the tabs element.

https://reviewboard.mozilla.org/r/239350/#review247302

Great, thanks!

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8970592 [details]
Bug 1456530 - Stop dispatching the select event on the tabs element.

https://reviewboard.mozilla.org/r/239350/#review247322

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61d7c365ea76
Stop dispatching the select event on the tabs element. r=mconley

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c26a61f65c3
Backed out changeset 61d7c365ea76 for failing crashtest dom/base/crashtests/354645-1.xul on a CLOSED TREE

Comment 6

[Tiberius Oros[:tiberius_oros]]

Backed out changeset 61d7c365ea76 (bug 1456530) for failing crashtest dom/base/crashtests/354645-1.xul

https://hg.mozilla.org/integration/autoland/rev/3c26a61f65c304f47eaf14b364e53352f5e533b7
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=61d7c365ea76a3dc1b7cf7f4320ea17123a30a98

https://treeherder.mozilla.org/logviewer.html#?job_id=177308891&repo=autoland&lineNumber=2037

19:21:08     INFO -  REFTEST TEST-START | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:21:08     INFO -  REFTEST TEST-LOAD | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul | 106 / 3550 (2%)
19:26:08    ERROR -  REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul | load failed: timed out waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST INFO | Saved log: START file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering WaitForTestEnd
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
19:26:08     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: dispatching MozReftestInvalidate
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] Webrender enabled, sending update whole canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: Updating entire canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] Webrender enabled, sending update whole canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: Updating entire canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST TEST-END | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8970592 [details]
Bug 1456530 - Stop dispatching the select event on the tabs element.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239350/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbd75c94a075
Stop dispatching the select event on the tabs element. r=mconley

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fbd75c94a075