Closed Bug 1456530 Opened 6 years ago Closed 6 years ago

Stop dispatching the select event on the tabs element

Categories

(Toolkit :: UI Widgets, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

This appears to be unused and is redundant with the select event on the tabpanels element.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=721210d9508f300c148cf7ad51da9826e0e2d700
Attachment #8970592 - Flags: review?(enndeakin)
Priority: -- → P5
Attachment #8970592 - Flags: review?(enndeakin) → review?(mconley)
Comment on attachment 8970592 [details]
Bug 1456530 - Stop dispatching the select event on the tabs element.

https://reviewboard.mozilla.org/r/239350/#review247302

Great, thanks!
Attachment #8970592 - Flags: review?(mconley) → review+
Comment on attachment 8970592 [details]
Bug 1456530 - Stop dispatching the select event on the tabs element.

https://reviewboard.mozilla.org/r/239350/#review247322
Attachment #8970592 - Flags: review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61d7c365ea76
Stop dispatching the select event on the tabs element. r=mconley
Backout by toros@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c26a61f65c3
Backed out changeset 61d7c365ea76 for failing crashtest dom/base/crashtests/354645-1.xul on a CLOSED TREE
Backed out changeset 61d7c365ea76 (bug 1456530) for failing crashtest dom/base/crashtests/354645-1.xul

https://hg.mozilla.org/integration/autoland/rev/3c26a61f65c304f47eaf14b364e53352f5e533b7
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=61d7c365ea76a3dc1b7cf7f4320ea17123a30a98

https://treeherder.mozilla.org/logviewer.html#?job_id=177308891&repo=autoland&lineNumber=2037

19:21:08     INFO -  REFTEST TEST-START | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:21:08     INFO -  REFTEST TEST-LOAD | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul | 106 / 3550 (2%)
19:26:08    ERROR -  REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul | load failed: timed out waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST INFO | Saved log: START file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering WaitForTestEnd
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
19:26:08     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: dispatching MozReftestInvalidate
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] Webrender enabled, sending update whole canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: Updating entire canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] Webrender enabled, sending update whole canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: Updating entire canvas for invalidation
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
19:26:08     INFO -  REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
19:26:08     INFO -  REFTEST TEST-END | file:///Z:/task_1525720068/build/tests/reftest/tests/dom/base/crashtests/354645-1.xul
Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbd75c94a075
Stop dispatching the select event on the tabs element. r=mconley
https://hg.mozilla.org/mozilla-central/rev/fbd75c94a075
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Depends on: 1459994
You need to log in before you can comment on or make changes to this bug.