Closed Bug 1456543 Opened Last year Closed Last year

Add a way to start GV test without a particular delegate

Categories

(GeckoView :: General, enhancement, P3)

All
Android
enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(4 files)

GV tests registers all delegates on startup, but some tests may need a particular delegate to be null.
Comment on attachment 8970599 [details]
Bug 1456543 - 1. Add @NullDelegate test annotation;

https://reviewboard.mozilla.org/r/239358/#review245102

Thanks, this fixes a big concern I had with the initial mega-delegate approach.
Attachment #8970599 - Flags: review?(snorp) → review+
Comment on attachment 8970600 [details]
Bug 1456543 - 2. Add some @NullDelegate tests;

https://reviewboard.mozilla.org/r/239360/#review245104
Attachment #8970600 - Flags: review?(snorp) → review+
Comment on attachment 8970601 [details]
Bug 1456543 - 3. Add test for updating module state during transfer;

https://reviewboard.mozilla.org/r/239362/#review245168
Attachment #8970601 - Flags: review?(esawin) → review+
Comment on attachment 8970602 [details]
Bug 1456543 - 4. Add test for loading without navigation delegate;

https://reviewboard.mozilla.org/r/239364/#review245170

Does that pass?
Attachment #8970602 - Flags: review?(esawin) → review+
Priority: -- → P3
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/429200bd5119
1. Add @NullDelegate test annotation; r=snorp
https://hg.mozilla.org/integration/autoland/rev/206d01e57d0d
2. Add some @NullDelegate tests; r=snorp
https://hg.mozilla.org/integration/autoland/rev/c3888fb8c222
3. Add test for updating module state during transfer; r=esawin
https://hg.mozilla.org/integration/autoland/rev/0ec752913e96
4. Add test for loading without navigation delegate; r=esawin
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.