1456543 - Add a way to start GV test without a particular delegate

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

GV tests registers all delegates on startup, but some tests may need a particular delegate to be null.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1456543 - 1. Add @NullDelegate test annotation;

Add an annotation for setting a particular delegate to null on test
start instead of to the proxy object. Assert that a null-delegate is
never used for any of the wait or delegate methods, because those
methods would never succeed with a null-delegate.

Review commit: https://reviewboard.mozilla.org/r/239358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239358/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1456543 - 2. Add some @NullDelegate tests;

Add some test for proper @NullDelegate behavior.

Review commit: https://reviewboard.mozilla.org/r/239360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239360/

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1456543 - 3. Add test for updating module state during transfer;

Add a test for correctly updating module states after transferring, so
that, for example, if we transfer a session with a null delegate to
another session with a non-null delegate, the corresponding module will
be automatically enabled.

Review commit: https://reviewboard.mozilla.org/r/239362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239362/

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1456543 - 4. Add test for loading without navigation delegate;

We should be able to load pages without a navigation delegate attached.

Review commit: https://reviewboard.mozilla.org/r/239364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239364/

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8970599 [details]
Bug 1456543 - 1. Add @NullDelegate test annotation;

https://reviewboard.mozilla.org/r/239358/#review245102

Thanks, this fixes a big concern I had with the initial mega-delegate approach.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8970600 [details]
Bug 1456543 - 2. Add some @NullDelegate tests;

https://reviewboard.mozilla.org/r/239360/#review245104

Comment 7

[Eugen Sawin [:esawin]]

Comment on attachment 8970601 [details]
Bug 1456543 - 3. Add test for updating module state during transfer;

https://reviewboard.mozilla.org/r/239362/#review245168

Comment 8

[Eugen Sawin [:esawin]]

Comment on attachment 8970602 [details]
Bug 1456543 - 4. Add test for loading without navigation delegate;

https://reviewboard.mozilla.org/r/239364/#review245170

Does that pass?

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8970599 [details]
Bug 1456543 - 1. Add @NullDelegate test annotation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239358/diff/1-2/

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8970600 [details]
Bug 1456543 - 2. Add some @NullDelegate tests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239360/diff/1-2/

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8970601 [details]
Bug 1456543 - 3. Add test for updating module state during transfer;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239362/diff/1-2/

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8970602 [details]
Bug 1456543 - 4. Add test for loading without navigation delegate;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239364/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/429200bd5119
1. Add @NullDelegate test annotation; r=snorp
https://hg.mozilla.org/integration/autoland/rev/206d01e57d0d
2. Add some @NullDelegate tests; r=snorp
https://hg.mozilla.org/integration/autoland/rev/c3888fb8c222
3. Add test for updating module state during transfer; r=esawin
https://hg.mozilla.org/integration/autoland/rev/0ec752913e96
4. Add test for loading without navigation delegate; r=esawin

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/429200bd5119
https://hg.mozilla.org/mozilla-central/rev/206d01e57d0d
https://hg.mozilla.org/mozilla-central/rev/c3888fb8c222
https://hg.mozilla.org/mozilla-central/rev/0ec752913e96