1456663 - Make a preference to open webconsole.html directly in the Browser Console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Brian Grinstead [:bgrins]]

Things like menus don't currently work, but we can get the code landed to make testing easier

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1456663 - Add a preference to open webconsole.html directly in the Browser Console;

This makes it easier to test top-level HTML window support. We continue to use the
XUL wrapper document unless if the pref is changed.

Review commit: https://reviewboard.mozilla.org/r/240096/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240096/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8971326 [details]
Bug 1456663 - Add a preference to open webconsole.html directly in the Browser Console;

https://reviewboard.mozilla.org/r/240096/#review246056

so everything work when the pref is false, but when true, the jsconsole won't open. Is it expected ? If so, maybe it should be a bit clearer in the commit message :)

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)
> Comment on attachment 8971326 [details]
> Bug 1456663 - Add a preference to open webconsole.html directly in the
> Browser Console;
> 
> https://reviewboard.mozilla.org/r/240096/#review246056
> 
> so everything work when the pref is false, but when true, the jsconsole
> won't open. Is it expected ? If so, maybe it should be a bit clearer in the
> commit message :)

I think this should be fixed as of Bug 1454445 (there was an issue where there wasn't any default height/width)

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8971326 [details]
Bug 1456663 - Add a preference to open webconsole.html directly in the Browser Console;

https://reviewboard.mozilla.org/r/240096/#review246170

r+ since it doesn' break current behaviour

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9bd9695b7e0
Add a preference to open webconsole.html directly in the Browser Console;r=nchevobbe

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a9bd9695b7e0