Closed Bug 1456703 Opened 2 years ago Closed 2 years ago

Remove nsIDOMXULTextBoxElement

Categories

(Core :: DOM: Core & HTML, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(2 files)

As far as I can tell this is used for two things (https://searchfox.org/mozilla-central/search?q=nsIDOMXULTextboxElement&path=)

1) In a few JS callers via instanceof checks
2) In nsFocusManager::GetRedirectedFocus to get the `inputField` attribute from JS (which evaluates to the HTML input/textarea tag in the XBL anon content).

For (1) we should be able to swap them out with tag name checks, and for (2) we should be able to directly reach into the anon content to get the HTML tag.

Once it's gone we can stop having the textbox (and child bindings) implement it.
Blocks: 1455676
Attachment #8970789 - Flags: review?(enndeakin)
Attachment #8970790 - Flags: review?(enndeakin)
Priority: -- → P3
Comment on attachment 8970789 [details]
Bug 1456703 - Stop using nsIDOMXULTextBoxElement to detect XUL textboxes

https://reviewboard.mozilla.org/r/239552/#review245760

::: toolkit/modules/sessionstore/FormData.jsm:208
(Diff revision 1)
>          continue;
>        }
>  
>        if (node instanceof Ci.nsIDOMHTMLInputElement ||
>            ChromeUtils.getClassName(node) === "HTMLTextAreaElement" ||
> -          node instanceof Ci.nsIDOMXULTextBoxElement) {
> +          node.localName == "textbox") {

This should check the namespace
Attachment #8970789 - Flags: review?(enndeakin) → review+
Comment on attachment 8970790 [details]
Bug 1456703 - Remove nsIDOMXULTextBoxElement

https://reviewboard.mozilla.org/r/239554/#review245762
Attachment #8970790 - Flags: review?(enndeakin) → review+
Will rebase around Bug 1456588 which is on inbound
Depends on: 1456588
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b22f31de49a87949c0625cda8d72c0a46cd21b13 -d 356d8af4a2b9: rebasing 460639:b22f31de49a8 "Bug 1456703 - Stop using nsIDOMXULTextBoxElement to detect XUL textboxes r=enndeakin+6102"
rebasing 460640:47ac4dd8a607 "Bug 1456703 - Remove nsIDOMXULTextBoxElement r=enndeakin+6102" (tip)
other [source] changed dom/interfaces/xul/nsIDOMXULTreeElement.idl which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
merging dom/interfaces/xul/moz.build
warning: conflicts while merging dom/interfaces/xul/moz.build! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e0ca85e6970
Stop using nsIDOMXULTextBoxElement to detect XUL textboxes r=enndeakin+6102
https://hg.mozilla.org/integration/autoland/rev/ef26c0022369
Remove nsIDOMXULTextBoxElement r=enndeakin+6102
https://hg.mozilla.org/mozilla-central/rev/3e0ca85e6970
https://hg.mozilla.org/mozilla-central/rev/ef26c0022369
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.