1456756 - [TreeView] Left arrow on non expandable or collapsed node should select parent node.

Status: VERIFIED FIXED

(DevTools :: Shared Components, defect)

Description

[Cristian Craciun]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180424100107

[Affected versions]:
Nightly 61.0a1

[Affected Platforms]:
All

[Prerequisites]:
Accessibility tab is opened and enabled

[Steps to reproduce]: 
1.Click the "document" item from the "Role" panel.
2.Select the first line without a dropdown arrow
3.Press the "Left arrow" key and observe what happens next.

[Expected result]:
-The "document" parent row should be selected 
Please see Comment 1 from bug 1439630

[Actual result]:
-Nothing happens, the "Left arrow" key is not used to navigate through lines.

Note that in the Inspector Tab/Properties panel for example, pressing the "Left arrow" key on a child row without dropdown arrow, moves the selected row back to the parent and pressing again the "Left arrow" key closes the child row.

Comment 1

[Cristian Craciun]

Please note that the issue is also occurring when using the "Right arrow" key.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Cristian Craciun from comment #1)
> Please note that the issue is also occurring when using the "Right arrow"
> key.

Right arrow navigate to next node is not desired and is confusing to a11y users. We disable it by default in the VirtualizedTree component.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1456756 patch

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8981233 [details] [diff] [review]
1456756 patch

Review of attachment 8981233 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

R+, assuming try is green.

Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc76999d8ee0
select parent row if available when ArrowLeft is pressed on collapsed or non-expandable row. r=Honza

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fc76999d8ee0

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1456756 updated patch

Carry over

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8982209 [details] [diff] [review]
1456756 updated patch

[Feature/Bug causing the regression]: Not a regression, supports a11y inspector deliverable for Fx61
[User impact if declined]: Users won't be able to use keyboard to jump to parent accessible object in accessibility tree when pressing ArrowLeft.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Same STR as in description.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just improves keyboard navigation, when pressing left arrow within TreeView
[String changes made/needed]: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8982209 [details] [diff] [review]
1456756 updated patch

a11y inspector improvement. Approved for 61.0b11.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5db81a8b00dc

Comment 11

[Rares Doghi, Desktop QA]

Hi Everyone , i managed to reproduce this issue using the 61.0a1 (2018-05-01) version of Nightly but i can no longer reproduce this issue on the later versions of it.
I will mark this issue accordingly.