14568 - Autocomplete not working now

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[esther]

Using 1999092112 on win98 (still checking linux and mac) auto complete on
Address Book is not working as it did in earlier builds.  Auto complete use to
work when typing in a partial name then pressing <Enter>.  Now <Enter> completes
the name by adding the domain name even though there is a partial match in my
Address book to a domain other than @netscape.com.
I have [e-mail] in my address book.  When I type in cara<Enter> I
get [e-mail] instead of [e-mail].  I have the preference
set to match against Address Books only.

1. Launch Messenger
2. Click New Msg
3. Type in part of an email address that is in your personal address book
and does not have @netscape.com as the domain, then press <Enter>

Result: @netscape.com gets appended to what you have typed
Expected: the first match against the character you typed with a name in your
personal address book to name complete on the To: line.

Comment 1

[hangas]

I heard this was fixed yesterday, but sending to JF to confirm.

Comment 2

[Jean-Francois Ducarroz]

I fix several other problems last night but this one is new. Should be easy to
fix it.

Comment 3

[Jean-Francois Ducarroz]

I found the problem. It has been introduced when adding the history AB to the
search path. In fact AC was working only agains the history AB. We forget to
populate the card of the personal AB.

Comment 4

[Jean-Francois Ducarroz]

Attachment: diff of the fix for this bug

Comment 5

[Jean-Francois Ducarroz]

attached diff of the fix. Scott, could you review my fix please?

Comment 6

[Scott MacGregor]

Ahh that's why name completion was only working on the history address book and
not the personal ab =).

Consider the fix reviewed.

Comment 7

[Phil Peterson]

Move milestone stoppers to M10

Comment 8

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 9

[esther]

Using 19991003 on win98 and 19991001 on mac and linux this is working now.
Note: Autocomplete works as before with the exception that it matches against
the collected abook first (see bug 15192) instead of Personal Abook.  It will
match against the Personal abook now only if there is no match in the Collected
Abook since we only make one match at this time it won't look at the Personal in
 this case.  Other bugs cover the exceptions.  Verififed