Closed Bug 1456824 Opened 7 years ago Closed 6 years ago

[meta] Implement proper GC support for wasm

Categories

(Core :: JavaScript: WebAssembly, enhancement, P2)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox62 --- fix-optional

People

(Reporter: bbouvier, Unassigned)

References

Details

(Keywords: meta)

We made a hack that disables GCs while wasm is running, but this lead to a flurry of fuzz bugs because many places in the engine check that GC can happen (either explicitly through `!suppressedGC` or implicitly after a check that an incremental GC has actually happened, for instance). At some point we should implement proper GC support. At this point, we need stack maps at the following locations: - before a call (direct or indirect, internal or external; except for leaf functions) - before an interrupt check (which could trigger an urgent GC) - before a memory allocation (when we implement gc.new in wasm) - (other places I can't think of right now)
status-firefox62: --- → fix-optional
Priority: -- → P2
Component: JavaScript Engine: JIT → Javascript: Web Assembly
Blocks: 1487329
Depends on: 1476251
Depends on: 1488162
Summary: wasm: Implement actual GC support in wasm → [meta] Implement proper GC support for wasm
Blocks: 1488205
No longer blocks: 1487329
All those hacks were just removed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.