1456847 - Could not fetch implementation for Roll-out/Roll-back

Status: RESOLVED WONTFIX

(Firefox :: Normandy Client, defect, P5)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]
This scenario involves server update to support roll-out/roll-back and Normandy client which does not support it.

[Steps:]
1. No recipes are actually required.
2. Create new profile, set the pref. to point to Normandy Staging server:
user_pref("security.content.signature.root_hash", "DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90");
user_pref("extensions.shield-recipe-client.api_url", "https://normandy.stage.mozaws.net/api/v1");
user_pref("app.normandy.dev_mode", true);

3. Open Firefox (beta60 or release59 are fine)
4. Open Browser console.

[Actual Result:]
1524662331627	app.normandy.recipe-runner	WARN	Could not fetch implementation for preference-rollout:: TypeError: url is null (resource://normandy/lib/NormandyApi.jsm:60:1) JS Stack trace: [e-mail]:60:1
[e-mail]:173:39
[e-mail]:304:38
1524662331628	app.normandy.recipe-runner	WARN	Could not fetch implementation for preference-rollback:: TypeError: url is null (resource://normandy/lib/NormandyApi.jsm:60:1) JS Stack trace: [e-mail]:60:1
[e-mail]:173:39
[e-mail]:304:38

[Expected Result:]
Not entirely sure what the expected result should actually be, I will deffer it to Normandy crew.

Comment 1

[Michael Cooper [:mythmon]]

This is sort of expected: we now have actions that don't have implementations on the server, and so don't have implementation urls. Since this is a WARN level log message, it indicates that other actions and recipes should work fine. It may be good to include a dummy url in these fields for older clients though, to avoid the noise in the console.

Comment 2

[Michael Cooper [:mythmon]]

I'm setting the tracking flags to represent what I expect to be true. This is a change to the server in support for preference-rollout, which are in Firefox 61. Firefox 60 and below will work, but print a warning.

Comment 3

[Adrian Florinescu [:aflorinescu]]

Mike, AFAIK, we do not intend to fix this for ESR60 and Firefox 60, so if that's the case, could you update the flags for those versions?
Also, what I'd expect from this bug is for Normandy to handle future types of recipes in 61/62 that we might introduce further along the line(63+), but I wonder if, for better clarity, we shouldn't won't fix this one and open a new issue particularly to handle that solution.

Comment 4

[Michael Cooper [:mythmon]]

I'll close this as WONTFIX. Future versions of Firefox aren't expected to hit this bug, and the imapact on old versions isn't enough to warrant a dot release.