Closed Bug 1456858 Opened 4 years ago Closed 4 years ago

Follow-up to bug 1433642 to address late review comments

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jorendorff, Assigned: sfink)

Details

Attachments

(1 file, 1 obsolete file)

Flags: needinfo?(sphink)
(If these comments are rendered moot by the next stack of patches on structured cloning, *great*. Dup away.)
Priority: -- → P2
Flags: needinfo?(sphink)
Attached patch structured clone comment fixups (obsolete) — Splinter Review
I hope to make some of this unnecessary soon, but I think it's worth applying your feedback in the meantime. Much of it carries over anyway. Thanks.
Attachment #8970999 - Flags: review?(jorendorff)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Oops, neglected to update the error message.
Attachment #8971005 - Flags: review?(jorendorff)
Attachment #8970999 - Attachment is obsolete: true
Attachment #8970999 - Flags: review?(jorendorff)
Comment on attachment 8971005 [details] [diff] [review]
structured clone comment fixups

Review of attachment 8971005 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8971005 - Flags: review?(jorendorff) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6529717260a2
structured clone comment fixups, r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/6529717260a2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.