1456879 - Clean up spell checker not to use nsIDOM* if possible

Status: RESOLVED FIXED

(Core :: Spelling checker, enhancement)

Description

[Makoto Kato [:m_kato] (PTO until 5/6)]

Without XPCOM and related method, I will remove dependencies of nsIDOM* from spellchecker.

Comment 1

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: Bug 1456879 - Clean up spellchecker not to use nsIDOM* if possible.

Without XPCOM and related method, I want to remove dependencies of nsIDOM*
from spellchecker.  Also, it is unnecessary to use nsISelectionPrivate since
we can use mozilla::dom::Selection instead.

Review commit: https://reviewboard.mozilla.org/r/239656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239656/

Comment 2

[Makoto Kato [:m_kato] (PTO until 5/6)]

Comment on attachment 8970903 [details]
Bug 1456879 - Clean up spellchecker not to use nsIDOM* if possible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239656/diff/1-2/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Comment on attachment 8970903 [details]
Bug 1456879 - Clean up spellchecker not to use nsIDOM* if possible.

https://reviewboard.mozilla.org/r/239656/#review245574

::: extensions/spellcheck/src/mozInlineSpellChecker.cpp:1136
(Diff revision 2)
>    range.swap(*aRange);
>    return NS_OK;
>  }
>  
>  nsresult
> -mozInlineSpellChecker::SpellCheckBetweenNodes(nsIDOMNode *aStartNode,
> +mozInlineSpellChecker::SpellCheckBetweenNodes(nsINode *aStartNode,

nit: nsINode* aStartNode (position of *).

::: extensions/spellcheck/src/mozInlineSpellChecker.cpp:1138
(Diff revision 2)
>  }
>  
>  nsresult
> -mozInlineSpellChecker::SpellCheckBetweenNodes(nsIDOMNode *aStartNode,
> +mozInlineSpellChecker::SpellCheckBetweenNodes(nsINode *aStartNode,
>                                                int32_t aStartOffset,
> -                                              nsIDOMNode *aEndNode,
> +                                              nsINode *aEndNode,

ditto.

::: extensions/spellcheck/src/mozInlineSpellWordUtil.cpp:246
(Diff revision 2)
> -mozInlineSpellWordUtil::GetRangeForWord(nsIDOMNode* aWordNode,
> +mozInlineSpellWordUtil::GetRangeForWord(nsINode* aWordNode,
>                                          int32_t aWordOffset,
>                                          nsRange** aRange)
>  {
>    // Set our soft end and start
> -  nsCOMPtr<nsINode> wordNode = do_QueryInterface(aWordNode);
> +  NodeOffset pt = NodeOffset(aWordNode, aWordOffset);

nit: NodeOffset pt(aWordNode, aWordOffset);

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a4c83d8d15
Clean up spellchecker not to use nsIDOM* if possible. r=masayuki

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c7a4c83d8d15