1456886 - (bmo-link-preview) Implement link descriptions client-side and remove from server-side comment rendering

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

Right now it seems that links to bugs and attachments get descriptive text added.
This prevents caching rendered comments in general and comment rendering is known to be slow.

Also, when we switch to markdown bug 999 would get a link description / hover text, but `[Bug 999](https://bugzilla.mozilla.org/show_bug.cgi?id=999)` would not.

Thus this bug involves a few things:

- remove the this feature from the backend
- add a similar front-end feature.
- audit all extensions that implement 'bug_format_comment'

To get started with the backend part, the entry point to comment rendering is here:

https://github.com/mozilla-bteam/bmo/blob/master/Bugzilla/Template.pm#L140

The bug link stuff is here:

https://github.com/mozilla-bteam/bmo/blob/master/Bugzilla/Template.pm#L316

The attachment stuff is more than just a hover-element, unfortunately:

https://github.com/mozilla-bteam/bmo/blob/master/Bugzilla/Template.pm#L264

Comment 1

[Dylan Hardison [:dylan] (he/him)]

For implementing this, I recommend at least two separate pull requests -- one for the backend removal, and the other for the frontend work. They both need to land at the same time but it will separate review concerns.

Also a great degree of freedom to change exactly how attachment / bug link preview works is granted for this.
Trying to do a 1:1 preservation of the existing feature is not desired.

Comment 2

[Israel Madueme [:imadueme]]

Attachment: Github PR #571

Comment 3

[Kohei Yoshino [:kohei]]

This API can be used to load descriptions depending on the link's visibility: https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API

Comment 4

[Kohei Yoshino [:kohei]]

Also to render comments in Markdown client-side, show images inline, or whatever. The API is still new but since we no longer support IE, we can start using it today :)

Comment 5

[Israel Madueme [:imadueme]]

Closing this to remove it from my queue, https://bugzilla.mozilla.org/show_bug.cgi?id=1456878 (which contains these changes) will remain open until markdown is landed. Perhaps we can also file a new bug in the future to integrate the Intersection Observer API.