Closed Bug 1456913 Opened 7 years ago Closed 7 years ago

Don't use potentially async signal unsafe STL iterators in InjectiveMultimap

Categories

(Core :: IPC, enhancement)

Product:
Core
Component:
IPC
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jld, Unassigned)

References

Details

According to https://crbug.com/331459, some implementations of STL iterators can take locks for debugging; I don't know the details of which implementations are affected under which conditions. This is a problem because they're used in the IPC file descriptor remapping, which needs to be async signal safe because it runs after fork. We're using an old version of the code that was fixed in that bug, so we may need to apply similar changes. (Would we even notice if we had tests deadlocking in process creation like that? Could this be happening on automation and buried in some generic timeout bug, or scattered among a lot of bugs for whatever test case happens to get stuck?)
Fixed (by rewriting) in bug 1456911.
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1456911
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.