Closed Bug 1456962 Opened 6 years ago Closed 5 years ago

Update default channel attributes for DynamicsCompressorNode

Categories

(Core :: Web Audio, defect, P2)

Product:
Core
Component:
Web Audio
Version:
57 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: toy.raymond, Assigned: valentin.millet39)

References

Details

Attachments

(2 files)

Bug 1456962 - Update default channel attributes for DynamicsCompressorNode r?padenot
47 bytes, text/x-phabricator-request
Details | Review
Bug 1456962 - Update WPT expectations for ctor-dynamicscompressor.html.
47 bytes, text/x-phabricator-request
Details | Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

c = new AudioContext()
n = new DynamicsCompressorNode(c)


Actual results:

n.channelCountMode should be "clamped-max", not "explicit"
n.channelCountMode = "max" works, but shouldn't.
n.channelCount = 3 works, but shouldn't.
Component: Untriaged → Web Audio
Product: Firefox → Core
Rank: 15
Priority: -- → P2
See Also: → 1443224
Summary: DynamicsCompressor constructor → Update default channel attributes for DynamicsCompressorNode
Assignee: nobody → valentin.millet39
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d279320478d
Update default channel attributes for DynamicsCompressorNode r=padenot
https://hg.mozilla.org/integration/autoland/rev/d99109729f40
Update WPT expectations for ctor-dynamicscompressor.html.

https://hg.mozilla.org/mozilla-central/rev/0d279320478d
https://hg.mozilla.org/mozilla-central/rev/d99109729f40

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.