1456973 - Add explicit ToNumber in wrappedCompareFn in TypedArraySort

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P2)

Description

[André Bargull [:anba]]

https://searchfox.org/mozilla-central/rev/36dec78aecc40539ecc8d78e91612e38810f963c/js/src/builtin/TypedArray.js#1213
---
// Step a.
var v = comparefn(x, y);
---

should instead read:

---
// Step a.
var v = +comparefn(x, y);
---



Test case:
---
var ta = new Int32Array(4);
var ab = ta.buffer;

ta.sort(function(a, b) {
  print("COMPARE");
  detachArrayBuffer(ab);
  return {
    [Symbol.toPrimitive]() { print("TO_PRIMITIVE"); }
  };
});
---

Expected: Prints "COMPARE" and "TO_PRIMITIVE"
Actual: Prints only "COMPARE"

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Add explicit ToNumber in wrappedCompareFn in TypedArraySort.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 9002825 [details] [diff] [review]
Add explicit ToNumber in wrappedCompareFn in TypedArraySort.

Review of attachment 9002825 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.

r=me, but this test belongs in test262. Now is a good time to figure out js/src/tests/test262-export.py.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e65beb5c226
Add explicit ToNumber in wrappedCompareFn in TypedArraySort. r=jorendorff

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4e65beb5c226