Closed Bug 1456980 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10643 - Move WebAudio node constructor tests to WPT

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10643 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10643
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:
>  Move WebAudio node constructor tests to WPT
>  
>  Move the constructor tests.  Manually verified that Firefox either
>  passes the tests or fails because of bugs in Firefox.
>  
>  Bug: 745778
>  Change-Id: Iee14d9c7531dc0094bac86daede5d62299c5fb93
>  Reviewed-on: https://chromium-review.googlesource.com/1028713
>  WPT-Export-Revision: 452e1c87989eec7d22ed668bfee47faf5e970f5d
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 16 tests and 695 subtests
OK     : 13
PASS   : 661
FAIL   : 34
ERROR  : 3

New tests that have failures or other problems:
/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html: ERROR
    < [default constructor] 1 out of 12 assertions were failed.: FAIL
    X node0.smoothingTimeConstant is not equal to 0.8. Got 0.800000011920929.: FAIL
    X node1 = new AnalyserNode(c, {"fftSize":32,"maxDecibels":1,"minDecibels":-13,"smoothingTimeConstant":0.125}) incorrectly threw IndexSizeError: "Index or size is negative or greater than the allowed amount".: FAIL
    X node1 instanceof AnalyserNode is not equal to true. Got false.: FAIL
/webaudio/the-audio-api/the-channelmergernode-interface/ctor-channelmerger.html
    # AUDIT TASK RUNNER FINISHED: 2 out of 5 tasks were failed.: FAIL
    < [constructor options] 2 out of 7 assertions were failed.: FAIL
    < [test AudioNodeOptions] 3 out of 13 assertions were failed.: FAIL
    X new ChannelMergerNode(c, {"channelCount":3}) did not throw an exception.: FAIL
    X new ChannelMergerNode(c, {"channelCountMode":"max"}) did not throw an exception.: FAIL
    X new ChannelMergerNode(c, {channelCount: 2}} did not throw an exception.: FAIL
    X new ChannelMergerNode(c, {channelCountMode: "clamped-max"}) did not throw an exception.: FAIL
    X new ChannelMergerNode(c, {channelCountMode: "max"}) did not throw an exception.: FAIL
/webaudio/the-audio-api/the-channelsplitternode-interface/ctor-channelsplitter.html: ERROR
    < [default constructor] 3 out of 7 assertions were failed.: FAIL
    X new ChannelSplitterNode(c, {channelCount: 6}} incorrectly threw InvalidStateError: "An attempt was made to use an object that is not, or is no longer, usable".: FAIL
    X node0.channelCount is not equal to 6. Got 2.: FAIL
    X node0.channelCountMode is not equal to explicit. Got max.: FAIL
    X node0.channelInterpretation is not equal to discrete. Got speakers.: FAIL
/webaudio/the-audio-api/the-constantsourcenode-interface/ctor-constantsource.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed.: FAIL
    < [default constructor] 1 out of 8 assertions were failed.: FAIL
    X node0.channelCount is not equal to 2. Got 1.: FAIL
/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 6 tasks were failed.: FAIL
    < [test AudioNodeOptions] 1 out of 13 assertions were failed.: FAIL
    X new ConvolverNode(c, {channelCountMode: "explicit"}) did not throw an exception.: FAIL
/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor.html
    # AUDIT TASK RUNNER FINISHED: 3 out of 5 tasks were failed.: FAIL
    < [constructor with options] 1 out of 10 assertions were failed.: FAIL
    < [default constructor] 1 out of 13 assertions were failed.: FAIL
    < [test AudioNodeOptions] 2 out of 18 assertions were failed.: FAIL
    X new DynamicsCompressorNode(c, {"channelCount":3}) did not throw an exception.: FAIL
    X new DynamicsCompressorNode(c, {"channelCountMode":"max"}) did not throw an exception.: FAIL
    X node0.channelCountMode is not equal to clamped-max. Got explicit.: FAIL
    X node1.channelCountMode is not equal to clamped-max. Got explicit.: FAIL
/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 5 tasks were failed.: FAIL
    < [constructor options] 1 out of 10 assertions were failed.: FAIL
    X new OscillatorNode(, {"type":"custom","periodicWave":{}}) incorrectly threw InvalidStateError: "An attempt was made to use an object that is not, or is no longer, usable".: FAIL
/webaudio/the-audio-api/the-pannernode-interface/ctor-panner.html: ERROR
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff155e599e24
[wpt PR 10643] - Move WebAudio node constructor tests to WPT, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec73f6441af6
[wpt PR 10643] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/ff155e599e24
https://hg.mozilla.org/mozilla-central/rev/ec73f6441af6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.