In bug 1455695 I added a helper class to correctly disconnect MozPromise thenables when the global is disconnected. We should use it in ServiceWorkerContainer.
Comment on attachment 8971021 [details] [diff] [review] Use DOMMozPromiseRequestHolder in ServiceWorkerContainer. r=baku This patch makes us use the DOMMozPromiseRequestHolder in the ServiceWorkerContainer methods.
Attachment #8971021 - Flags: review?(amarchesini)
Actually, we probably do need to wait for bug 1456466 so we can have the auto-suppressing CopyableErrorResult type. Otherwise disconnecting a rejected MozPromise here will assert that the ErrorResult was not consumed.
Attachment #8971021 - Flags: review?(amarchesini) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/43385aef5932 Use DOMMozPromiseRequestHolder in ServiceWorkerContainer. r=baku
You need to log in before you can comment on or make changes to this bug.