Use DOMMozPromiseRequestHolder in ServiceWorkerContainer

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P2
normal
RESOLVED FIXED
Last year
10 months ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

In bug 1455695 I added a helper class to correctly disconnect MozPromise thenables when the global is disconnected.  We should use it in ServiceWorkerContainer.
Priority: -- → P2
Comment on attachment 8971021 [details] [diff] [review]
Use DOMMozPromiseRequestHolder in ServiceWorkerContainer. r=baku

This patch makes us use the DOMMozPromiseRequestHolder in the ServiceWorkerContainer methods.
Attachment #8971021 - Flags: review?(amarchesini)
Depends on: 1457187
No longer depends on: 1455695
Actually, we probably do need to wait for bug 1456466 so we can have the auto-suppressing CopyableErrorResult type.  Otherwise disconnecting a rejected MozPromise here will assert that the ErrorResult was not consumed.
Depends on: 1456466
No longer depends on: 1457187
Attachment #8971021 - Flags: review?(amarchesini) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43385aef5932
Use DOMMozPromiseRequestHolder in ServiceWorkerContainer. r=baku
https://hg.mozilla.org/mozilla-central/rev/43385aef5932
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.