1456989 - [BinAST] CatchClause now contains a AssertedParameterScope

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

This corresponds to encoder change https://github.com/binast/binjs-ref/pull/113 .

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Note: I'm not entirely sure how to handle this yet.



When we parse an

Comment 2

[David Teller [:Yoric] - still alive but not very active]

When we parse an AssertedParameterScope, we use `parseContext_->functionScope()`, because we assume that we're currently parsing a function. This is not the case here, but what is the scope, exactly? Just the innermost scope?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

efaust, that's part of the mountain of stuff that I'll let you decide when to land, so as not to block your ongoing landing. Just to make things more fun, we'll need to land the matching binjs-ref patch: https://github.com/binast/binjs-ref/pull/113

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1456989 - Updating BinTokenReader{Simple, Multipart} tests data;

Review commit: https://reviewboard.mozilla.org/r/239948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239948/

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1456989 - CatchClause now contains a AssertedParameterScope;

This follows the spec changes and the binjs-ref change at https://github.com/binast/binjs-ref/pull/113 .

Review commit: https://reviewboard.mozilla.org/r/239950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239950/

Comment 6

[Tooru Fujisawa [:arai]]

Comment on attachment 8971152 [details]
Bug 1456989 - Updating BinTokenReader{Simple, Multipart} tests data;

https://reviewboard.mozilla.org/r/239948/#review245650

Comment 7

[Eric Faust [:efaust]]

Comment on attachment 8971153 [details]
Bug 1456989 - CatchClause now contains a AssertedParameterScope;

https://reviewboard.mozilla.org/r/239950/#review245920

Patch looks good to me. Not sure how bad the rebase will prove.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8971152 [details]
Bug 1456989 - Updating BinTokenReader{Simple, Multipart} tests data;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239948/diff/1-2/

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8971153 [details]
Bug 1456989 - CatchClause now contains a AssertedParameterScope;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239950/diff/1-2/

Comment 10

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8971152 [details]
Bug 1456989 - Updating BinTokenReader{Simple, Multipart} tests data;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239948/diff/2-3/

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8971153 [details]
Bug 1456989 - CatchClause now contains a AssertedParameterScope;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239950/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7135781f4a79
Updating BinTokenReader{Simple, Multipart} tests data;r=arai
https://hg.mozilla.org/integration/autoland/rev/0483a4252c05
CatchClause now contains a AssertedParameterScope;r=efaust

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7135781f4a79
https://hg.mozilla.org/mozilla-central/rev/0483a4252c05