1457013 - AudioBuffer ctor throws wrong exceptions with out-of-range arguments

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[toy.raymond]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Steps to reproduce:

Run

n0 = new AudioBuffer({"numberOfChannels":0,"length":1,"sampleRate":16000});
n1 = new AudioBuffer({numberOfChannels: 2, length: 10, sampleRate: 48000});
n1.getChannelData(3)



Actual results:

Construction of n0 threw an IndexSizeError.

Same thing if you set length to 1 or sampleRate to a rate that's not supported.

n1.getChannelData(3) threw SyntaxError


Expected results:

I was expecting NotSupportedError as mentioned in https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-createbuffer

Similarly, getChannelData(3) should throw IndexSizeError: https://webaudio.github.io/web-audio-api/#dom-audiobuffer-getchanneldata-channel

Comment 1

[toy.raymond]

Oops. I meant setting length to 0.

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1457013 - In AudioBuffer return NOT_SUPPORTED error message for various cases to align with the spec.

Review commit: https://reviewboard.mozilla.org/r/240040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240040/

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8971270 [details]
Bug 1457013 - In AudioBuffer return NOT_SUPPORTED error message for various cases to align with the spec.

https://reviewboard.mozilla.org/r/240040/#review245802

Comment 4

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=500cbd125e15ff0c847d4059675d23a16a640c22

Comment 5

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1457013 - Update AudioBuffer mochitest to expect not supported error.

Review commit: https://reviewboard.mozilla.org/r/240384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240384/

Comment 6

[Alex Chronopoulos [:achronop]]

Comment on attachment 8971270 [details]
Bug 1457013 - In AudioBuffer return NOT_SUPPORTED error message for various cases to align with the spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240040/diff/1-2/

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 8971624 [details]
Bug 1457013 - Update AudioBuffer mochitest to expect not supported error.

https://reviewboard.mozilla.org/r/240384/#review246438

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42439f5ecc0d
In AudioBuffer return NOT_SUPPORTED error message for various cases to align with the spec. r=padenot
https://hg.mozilla.org/integration/autoland/rev/d1623ae65516
Update AudioBuffer mochitest to expect not supported error. r=padenot

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/42439f5ecc0d
https://hg.mozilla.org/mozilla-central/rev/d1623ae65516

Comment 10

[Eric Shepherd [:sheppy]]

Documentation updated:

Added range information and exception info to https://developer.mozilla.org/en-US/docs/Web/API/AudioBuffer/AudioBuffer
Same kinds of changes to https://developer.mozilla.org/en-US/docs/Web/API/BaseAudioContext/createBuffer

Updated https://developer.mozilla.org/en-US/Firefox/Releases/61#Web_Audio_Media_and_WebRTC