Closed
Bug 1457051
Opened 7 years ago
Closed 7 years ago
Wrong function being used for WebIDL isInstance
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
3.08 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 1452786 uses InterfaceHasInstance, not InterfaceIsInstance. The two have pretty similar behavior, so no tests noticed this...
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8971111 -
Flags: review?(kyle)
|
||
Updated•7 years ago
|
Attachment #8971111 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e515ebef17d0
The WebIDL isInstance should be a pure brand check, not an instanceof-like check. r=qdot
|
||
Updated•7 years ago
|
Priority: -- → P2
|
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•