Closed Bug 1457071 Opened 2 years ago Closed 2 years ago

Implement the ability for the extension-storage engine to wipe all local data

Categories

(WebExtensions :: Storage, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

In bug 1409208 we are implementing the ability for the user to choose to remove all sync data from their profile when they disconnect Sync. However, the extension-storage engine doesn't implement this functionality.

I had a go at implementing this - it may be naive, but hopefully Ethan can help set me straight.
Comment on attachment 8971148 [details]
Bug 1457071 - allow all extension-storage data to be deleted from the profile.

https://reviewboard.mozilla.org/r/239940/#review245768

::: toolkit/components/extensions/test/xpcshell/test_ext_storage_sync.js:585
(Diff revision 2)
> +      server.installCollection("storage-sync-crypto");
> +      server.etag = 1000;
> +
> +      let newKeys = await extensionStorageSync.ensureCanSync([extensionId]);
> +      ok(newKeys.hasKeysFor([extensionId]), `key isn't present for ${extensionId}`);
> +
> +      let posts = server.getPosts();
> +      equal(posts.length, 1);
> +      const post = posts[0];
> +      assertPostedNewRecord(post);

Sorry this is a little clumsy!
Attachment #8971148 - Flags: review?(eglassercamp) → review+
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/bea414aba9b9
allow all extension-storage data to be deleted from the profile. r=glasserc
https://hg.mozilla.org/mozilla-central/rev/bea414aba9b9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(markh)
Flags: qe-verify-
Flags: needinfo?(markh)
Flags: in-testsuite+
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.