1457071 - Implement the ability for the extension-storage engine to wipe all local data

Status: RESOLVED FIXED

(WebExtensions :: Storage, enhancement)

Description

[Mark Hammond [:markh] [:mhammond]]

In bug 1409208 we are implementing the ability for the user to choose to remove all sync data from their profile when they disconnect Sync. However, the extension-storage engine doesn't implement this functionality.

I had a go at implementing this - it may be naive, but hopefully Ethan can help set me straight.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1457071 - allow all extension-storage data to be deleted from the profile.

Review commit: https://reviewboard.mozilla.org/r/239940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239940/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8971148 [details]
Bug 1457071 - allow all extension-storage data to be deleted from the profile.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239940/diff/1-2/

Comment 3

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8971148 [details]
Bug 1457071 - allow all extension-storage data to be deleted from the profile.

https://reviewboard.mozilla.org/r/239940/#review245768

::: toolkit/components/extensions/test/xpcshell/test_ext_storage_sync.js:585
(Diff revision 2)
> +      server.installCollection("storage-sync-crypto");
> +      server.etag = 1000;
> +
> +      let newKeys = await extensionStorageSync.ensureCanSync([extensionId]);
> +      ok(newKeys.hasKeysFor([extensionId]), `key isn't present for ${extensionId}`);
> +
> +      let posts = server.getPosts();
> +      equal(posts.length, 1);
> +      const post = posts[0];
> +      assertPostedNewRecord(post);

Sorry this is a little clumsy!

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8971148 [details]
Bug 1457071 - allow all extension-storage data to be deleted from the profile.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239940/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bea414aba9b9
allow all extension-storage data to be deleted from the profile. r=glasserc

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bea414aba9b9

Comment 7

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!