1457084 - Increase max chunk memory usage limit

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement, P3)

Description

[Michal Novotny [:michal]]

Current browser.cache.disk.max_priority_chunks_memory_usage and browser.cache.disk.max_chunks_memory_usage values are not sufficient for writing very large alternative data. The whole data is written at once and if it's larger then it will likely hit this limit.

Comment 1

[Michal Novotny [:michal]]

Attachment: diff-bug1457084-v1.patch

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8979750 [details] [diff] [review]
diff-bug1457084-v1.patch

Review of attachment 8979750 [details] [diff] [review]:
-----------------------------------------------------------------

please update also https://searchfox.org/mozilla-central/rev/eb51d734a8c06ac5973291be9bcc74ed4e999bca/modules/libpref/init/all.js#65-66

this patch actually doesn't have any effect as is.

Comment 3

[Michal Novotny [:michal]]

Attachment: patch v2

(In reply to Honza Bambas (:mayhemer) from comment #2)
> please update also
> https://searchfox.org/mozilla-central/rev/
> eb51d734a8c06ac5973291be9bcc74ed4e999bca/modules/libpref/init/all.js#65-66
> 
> this patch actually doesn't have any effect as is.

Right, thanks for catching this.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8979893 [details] [diff] [review]
patch v2

Review of attachment 8979893 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10f52bc1b0a4
Increase max chunk memory usage limit, r=mayhemer

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/10f52bc1b0a4