Closed Bug 1457084 Opened 2 years ago Closed 2 years ago

Increase max chunk memory usage limit

Categories

(Core :: Networking: Cache, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: michal, Assigned: michal)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file, 1 obsolete file)

Current browser.cache.disk.max_priority_chunks_memory_usage and browser.cache.disk.max_chunks_memory_usage values are not sufficient for writing very large alternative data. The whole data is written at once and if it's larger then it will likely hit this limit.
Attached patch diff-bug1457084-v1.patch (obsolete) — Splinter Review
Attachment #8979750 - Flags: review?(honzab.moz)
Comment on attachment 8979750 [details] [diff] [review]
diff-bug1457084-v1.patch

Review of attachment 8979750 [details] [diff] [review]:
-----------------------------------------------------------------

please update also https://searchfox.org/mozilla-central/rev/eb51d734a8c06ac5973291be9bcc74ed4e999bca/modules/libpref/init/all.js#65-66

this patch actually doesn't have any effect as is.
Attachment #8979750 - Flags: review?(honzab.moz) → review-
Attached patch patch v2Splinter Review
(In reply to Honza Bambas (:mayhemer) from comment #2)
> please update also
> https://searchfox.org/mozilla-central/rev/
> eb51d734a8c06ac5973291be9bcc74ed4e999bca/modules/libpref/init/all.js#65-66
> 
> this patch actually doesn't have any effect as is.

Right, thanks for catching this.
Attachment #8979750 - Attachment is obsolete: true
Attachment #8979893 - Flags: review?(honzab.moz)
Comment on attachment 8979893 [details] [diff] [review]
patch v2

Review of attachment 8979893 [details] [diff] [review]:
-----------------------------------------------------------------

thanks
Attachment #8979893 - Flags: review?(honzab.moz) → review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10f52bc1b0a4
Increase max chunk memory usage limit, r=mayhemer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/10f52bc1b0a4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.