1457120 - [Wayland] build error: ‘FontSlantStyle’/FontStretch has not been declared

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

After Bug 1436048 land it can't be build Gtk+/Wayland backend:

 0:27.87 In file included from /home/komat/tmp676-trunk-gtk3/src2/objdir/widget/gtk/Unified_cpp_widget_gtk2.cpp:11:
 0:27.87 /home/komat/tmp676-trunk-gtk3/src2/widget/gtk/nsLookAndFeel.cpp: In function ‘void GetSystemFontInfo(GtkStyleContext*, nsString*, gfxFontStyle*)’:
 0:27.87 /home/komat/tmp676-trunk-gtk3/src2/widget/gtk/nsLookAndFeel.cpp:712:25: error: ‘FontSlantStyle’ has not been declared
 0:27.87      aFontStyle->style = FontSlantStyle::Normal();
 0:27.87                          ^~~~~~~~~~~~~~
 0:27.87 /home/komat/tmp676-trunk-gtk3/src2/widget/gtk/nsLookAndFeel.cpp:730:27: error: ‘FontStretch’ has not been declared
 0:27.87      aFontStyle->stretch = FontStretch::Normal();
 0:27.87                            ^~~~~~~~~~~

Comment 1

[Martin Stránský [:stransky] (ni? me)]

we're missing mozilla:: namespace here.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1457120 - Use mozilla:: namespace at nsLookAndFeel module,

Review commit: https://reviewboard.mozilla.org/r/239990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239990/

Comment 3

[Jonathan Watt [:jwatt]]

Probably cleaner to put a 'using' statement at the top of the file.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8971203 [details]
Bug 1457120 - Use mozilla:: namespace at nsLookAndFeel module,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/239990/diff/1-2/

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to Jonathan Watt [:jwatt] from comment #3)
> Probably cleaner to put a 'using' statement at the top of the file.

Updated, Thanks.

Comment 6

[Jan Horak [:jhorak]]

Comment on attachment 8971203 [details]
Bug 1457120 - Use mozilla:: namespace at nsLookAndFeel module,

https://reviewboard.mozilla.org/r/239990/#review245758

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50355ef2f138
Use mozilla:: namespace at nsLookAndFeel module, r=jhorak

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/50355ef2f138

Comment 9

[Jonathan Watt [:jwatt]]

Thanks for fixing this!