1457131 - Investigate if we can remove itemId (aka parentId) from PlacesInsertionPoint

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Mark Banner (:standard8)]

Looking at the recent drag & drop / copy & paste code, it is fairly clear it no longer needs the itemId (aka parentId) in the insertionPoint.

The other uses seem to be mainly for the bookmarks properties dialog - there's a few places where it is used, but I think the dialog could simply do a promiseItemId, if it needs it at all.

This would help simplify at least some of the existing cases in tests where we're having to go and get the IDs rather than using GUIDs all the time.

Comment 1

[Mark Banner (:standard8)]

Having looked through a bit more, I'm pretty sure that the bookmark properties dialog no longer needs the id in the insertion point (though it does need to get it, but there's async methods available where we can easily do that).

Unfortunately the drag and drop parts are blocked by onDrop needing to be synchronous. That's bug 1382992.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1457131 - Remove itemId (aka parentId) from PlacesInsertionPoint. r=Standard8

Depends on D165766

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1457131 - Remove no longer necessary getConcreteItemId(). r=Standard8

Depends on D165767

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1457131 - Remove no longer necessary PlacesUtils.toolbarFolderId. r=Standard8

Depends on D165768

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1457131 - Remove no longer necessary PlacesUtils.placesRootId. r=Standard8

Depends on D165769

Comment 6

[Marco Bonardo [:mak]]

Attachment: Bug 1457131 - Remove no longer necessary PlacesUtils.bookmarksMenuFolderId. r=Standard8

Depends on D165770

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aa3ae050bab
Remove itemId (aka parentId) from PlacesInsertionPoint. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/5173f2ffbc1d
Remove no longer necessary getConcreteItemId(). r=Standard8
https://hg.mozilla.org/integration/autoland/rev/edc3b095d718
Remove no longer necessary PlacesUtils.toolbarFolderId. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/2321ee1c9ab1
Remove no longer necessary PlacesUtils.placesRootId. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/fdd9bc0c987b
Remove no longer necessary PlacesUtils.bookmarksMenuFolderId. r=Standard8

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3aa3ae050bab
https://hg.mozilla.org/mozilla-central/rev/5173f2ffbc1d
https://hg.mozilla.org/mozilla-central/rev/edc3b095d718
https://hg.mozilla.org/mozilla-central/rev/2321ee1c9ab1
https://hg.mozilla.org/mozilla-central/rev/fdd9bc0c987b