Open Bug 1457131 Opened 2 years ago Updated 2 years ago

Investigate if we can remove itemId (aka parentId) from PlacesInsertionPoint

Categories

(Firefox :: Bookmarks & History, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox61 --- affected

People

(Reporter: standard8, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Looking at the recent drag & drop / copy & paste code, it is fairly clear it no longer needs the itemId (aka parentId) in the insertionPoint.

The other uses seem to be mainly for the bookmarks properties dialog - there's a few places where it is used, but I think the dialog could simply do a promiseItemId, if it needs it at all.

This would help simplify at least some of the existing cases in tests where we're having to go and get the IDs rather than using GUIDs all the time.
Having looked through a bit more, I'm pretty sure that the bookmark properties dialog no longer needs the id in the insertion point (though it does need to get it, but there's async methods available where we can easily do that).

Unfortunately the drag and drop parts are blocked by onDrop needing to be synchronous. That's bug 1382992.
Depends on: 1382992
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.