Closed Bug 1457156 Opened 2 years ago Closed 2 years ago

Rename nsPIDOMWindow::mFocusedNode to mFocusedElement and rename its accessors

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

After bug 1457155 it's an Element.
Assignee: nobody → bzbarsky
Depends on: 1456588
Attachment #8971333 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e267d999797
Rename nsPIDOMWindow::mFocusedNode to reflect that it's an Element now.  r=mccr8
Backed out 2 changesets (bug 1457155, bug 1457156) for B failures in builds/worker/workspace/build/src/dom/html/HTMLObjectElement.cpp on a CLOSED TREE

Problematic push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8b2a6b54336cdb5e4f89138a94fc3c25adb1305a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=932c9e0e76fc75937fcc3652cd9dbc94e2c317a2&selectedJob=175829251
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=13b1094802143e1d2c05ae5c23749ed02712062d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=175829251&repo=mozilla-inbound&lineNumber=19845

[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -  /builds/worker/workspace/build/src/dom/html/HTMLObjectElement.cpp:198:26: error: no member named 'GetFocusedContent' in 'nsFocusManager'; did you mean 'GetFocusedElement'?
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -      focusedContent = fm->GetFocusedContent();
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -                           ^~~~~~~~~~~~~~~~~
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -                           GetFocusedElement
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -  /builds/worker/workspace/build/src/dom/base/nsFocusManager.h:70:26: note: 'GetFocusedElement' declared here
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -    mozilla::dom::Element* GetFocusedElement() { return mFocusedElement; }
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -                           ^
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  1 error generated.
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1024: recipe for target 'Unified_cpp_dom_html2.o' failed
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  make[4]: *** [Unified_cpp_dom_html2.o] Error 1
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/html'
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  make[4]: *** Waiting for unfinished jobs....
Flags: needinfo?(bzbarsky)
The problem was bug 1457155.
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eea837f5ac16
Rename nsPIDOMWindow::mFocusedNode to reflect that it's an Element now.  r=mccr8
https://hg.mozilla.org/mozilla-central/rev/eea837f5ac16
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.