1457156 - Rename nsPIDOMWindow::mFocusedNode to mFocusedElement and rename its accessors

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

After bug 1457155 it's an Element.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Rename nsPIDOMWindow::mFocusedNode to reflect that it's an Element now

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e267d999797
Rename nsPIDOMWindow::mFocusedNode to reflect that it's an Element now.  r=mccr8

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out 2 changesets (bug 1457155, bug 1457156) for B failures in builds/worker/workspace/build/src/dom/html/HTMLObjectElement.cpp on a CLOSED TREE

Problematic push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8b2a6b54336cdb5e4f89138a94fc3c25adb1305a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=932c9e0e76fc75937fcc3652cd9dbc94e2c317a2&selectedJob=175829251
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=13b1094802143e1d2c05ae5c23749ed02712062d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=175829251&repo=mozilla-inbound&lineNumber=19845

[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -  /builds/worker/workspace/build/src/dom/html/HTMLObjectElement.cpp:198:26: error: no member named 'GetFocusedContent' in 'nsFocusManager'; did you mean 'GetFocusedElement'?
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -      focusedContent = fm->GetFocusedContent();
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -                           ^~~~~~~~~~~~~~~~~
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -                           GetFocusedElement
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -  /builds/worker/workspace/build/src/dom/base/nsFocusManager.h:70:26: note: 'GetFocusedElement' declared here
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -    mozilla::dom::Element* GetFocusedElement() { return mFocusedElement; }
[task 2018-04-26T22:04:07.341Z] 22:04:07     INFO -                           ^
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  1 error generated.
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1024: recipe for target 'Unified_cpp_dom_html2.o' failed
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  make[4]: *** [Unified_cpp_dom_html2.o] Error 1
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/html'
[task 2018-04-26T22:04:07.342Z] 22:04:07     INFO -  make[4]: *** Waiting for unfinished jobs....

Comment 4

[Boris Zbarsky [:bzbarsky]]

The problem was bug 1457155.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eea837f5ac16
Rename nsPIDOMWindow::mFocusedNode to reflect that it's an Element now.  r=mccr8

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eea837f5ac16