1457168 - --enable-linker does not propogate the flags so that configure uses them

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Tom Ritter [:tjr]]

If one sets --enable-linker (I used lld) - configure will not use the linker for it's checks.

If one sets a CFLAG (I set -flto over here: https://searchfox.org/mozilla-central/rev/78dbe34925f04975f16cb9a5d4938be714d41897/build/moz.configure/toolchain.configure#1355 ) that requires the specific linker - one will get build errors because the linker is not specified.

Sample try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e319ccbf1772d782290a42d792222d25bf2a3e9e&filter-searchStr=cfi

You can see that even though I specify --enable-linker=lld it is not included in the configure command:

/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang -fgnu89-inline -B /builds/worker/workspace/build/src/gcc/bin -std=gnu99 -c -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -flto=thin -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pipe  -Qunused-arguments  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -flto=thin conftest.c 1>&5

Comment 1

[Kim Moir [:kmoir] ET]

:glandium - chmanchester suggested you might be able to help with this bug

Comment 2

[Mike Hommey [:glandium]]

I don't think we have any linkage tests in python configure yet, so I guess an easy way out here would be to add LINKER_LDFLAGS to LDFLAGS in old-configure.in. Not sure if that would need to be filtered out before reaching moz.build processing, though.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1457168 - Make configure tests use LINKER_LDFLAGS.

Because we have no linking configure test in python configure (yet), we
just make old-configure tests use LINKER_LDFLAGS, and make those flags
added to LDFLAGS by old-configure at the same time.

Review commit: https://reviewboard.mozilla.org/r/254704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254704/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8989690 [details]
Bug 1457168 - Make configure tests use LINKER_LDFLAGS.

https://reviewboard.mozilla.org/r/254704/#review262026

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de7abe2c2b3e
Make configure tests use LINKER_LDFLAGS. r=chmanchester

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/de7abe2c2b3e