Closed Bug 1457218 Opened 5 years ago Closed 5 years ago

Remove support for button[type="menu-button"]

Categories

(Toolkit :: XUL Widgets, task, P1)

Product:
Toolkit
Component:
XUL Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: ntim, Assigned: Paolo)

References

Details

Attachments

(3 files)

Bug 1457218 - Part 1 - Don't inherit from "menu-button-base" in the "download-subview-toolbarbutton" binding. r=bgrins
46 bytes, text/x-phabricator-request
bgrins
: review+
Details | Review
Bug 1457218 - Part 2 - Remove support for menu button types in notification bars. r=bgrins
46 bytes, text/x-phabricator-request
bgrins
: review+
Details | Review
Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins
46 bytes, text/x-phabricator-request
bgrins
: review+
surkov
: review+
Details | Review 
Triage: code cleanup.
Priority: -- → P5
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P5 → P1
The "menu-button" notification button type is unused, and the "menu" type is implemented using a normal button that opens a popup.

Depends on D4529
Depends on: 1487087
Comment on attachment 9004845 [details]
Bug 1457218 - Part 1 - Don't inherit from "menu-button-base" in the "download-subview-toolbarbutton" binding. r=bgrins

Brian Grinstead [:bgrins] has approved the revision.
Attachment #9004845 - Flags: review+
Comment on attachment 9004848 [details]
Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins

Brian Grinstead [:bgrins] has approved the revision.
Attachment #9004848 - Flags: review+
Comment on attachment 9004847 [details]
Bug 1457218 - Part 2 - Remove support for menu button types in notification bars. r=bgrins

Brian Grinstead [:bgrins] has approved the revision.
Attachment #9004847 - Flags: review+
Comment on attachment 9004848 [details]
Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins

alexander :surkov (:asurkov) has approved the revision.
Attachment #9004848 - Flags: review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce10788000f5
Part 1 - Don't inherit from "menu-button-base" in the "download-subview-toolbarbutton" binding. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2d52cbf726d
Part 2 - Remove support for menu button types in notification bars. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce3008e2f46
Part 3 - Remove the "menu-button" binding. r=surkov,bgrins
https://hg.mozilla.org/mozilla-central/rev/ce10788000f5
https://hg.mozilla.org/mozilla-central/rev/e2d52cbf726d
https://hg.mozilla.org/mozilla-central/rev/6ce3008e2f46
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Type: enhancement → task
Blocks: 509642
You need to log in before you can comment on or make changes to this bug.